Page MenuHomePhabricator

commands: don't check for merge.update() truthiness
ClosedPublic

Authored by indygreg on Mar 5 2018, 1:17 AM.

Details

Summary

AFAICT `stats` is always a tuple in these cases. We don't
need to check if the variable has a truthy value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 5 2018, 1:17 AM
durin42 requested changes to this revision.Mar 12 2018, 5:54 PM
durin42 added a subscriber: durin42.

Needs rebased, and the parent listed in the patch header isn't available for me. Can you give a rebase a shot?

This revision now requires changes to proceed.Mar 12 2018, 5:54 PM
indygreg updated this revision to Diff 6968.Mar 12 2018, 6:28 PM
This revision was automatically updated to reflect the committed changes.