This is an archive of the discontinued Mercurial Phabricator instance.

xdiff: remove unused flags parameter
ClosedPublic

Authored by quark on Mar 9 2018, 5:54 PM.

Details

Summary

After D2683, the flags parameter in some functions is no longer needed.
Thus removed.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Mar 9 2018, 5:54 PM
indygreg accepted this revision.Mar 9 2018, 6:20 PM
indygreg added a subscriber: indygreg.

Strictly speaking, we might want to bump the C extension version number because of the ABI change. But I'm not sure if these functions are exported or even used by our C extension. So it may not matter. It's an experimental feature right now, so I'm inclined to not care.

This revision is now accepted and ready to land.Mar 9 2018, 6:20 PM
This revision was automatically updated to reflect the committed changes.
quark added a comment.Mar 9 2018, 6:31 PM

I don't think the Python ".so"s should be consumed by non-Python "dlopen". So "version" doesn't change since Python API remains the same.