Page MenuHomePhabricator

sha1: allow selecting SHA-1 library at build time
ClosedPublic

Authored by simpkins on Aug 8 2017, 4:20 PM.

Details

Reviewers
ryanmce
Group Reviewers
Restricted Project
Commits
rFBHGX5eca64d9cba7: sha1: allow selecting SHA-1 library at build time
Summary

Add a #define which allows selecting between the sha1collisiondetection and
openssl SHA-1 implementations at build time.

For now setup.py always uses sha1collisiondetection, but we have some other
internal build environments where we will likely default to OpenSSL's SHA-1
implementation instead.

Test Plan

Confirmed the code builds and passes tests.

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

simpkins created this revision.Aug 8 2017, 4:20 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 8 2017, 4:20 PM
ryanmce accepted this revision.Aug 9 2017, 5:58 AM
This revision is now accepted and ready to land.Aug 9 2017, 5:58 AM
This revision was automatically updated to reflect the committed changes.