This is an archive of the discontinued Mercurial Phabricator instance.

cleanup: fix some latent open(path).read() et al calls we previously missed
ClosedPublic

Authored by durin42 on Mar 14 2018, 3:53 PM.

Details

Summary

This pattern was banned by check-code way back in 1b4b82063ce2 (may of
2011), but due to a regular expression rewriting bug in check-code
these particular callsites were never detected. Python 3.7 caught the
bug, which then exposed these errors.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.