This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2875

remotenames: introduce a config option to allow creation of remote bookmarks
Needs RevisionPublic

Authored by pulkit on Mar 15 2018, 9:49 AM.

Details

Reviewers
indygreg
marmoute
Group Reviewers
hg-reviewers
Summary

This patch introduces another config option which if set to true, we can create
new bookmarks on the server using push command. An earlier patch added
capability to push to a certain bookmark on the server. If bookmark was not
already present on the server, we errored out. With
remotenames.createremotebookmark config set, the push will create that bookmark
on the server.

This series serves as a great feature for people who use bookmarks as after this
you can push changesets to a bookmark which does not exists locally. In other
words, you can push your changesets to a bookmark without having it locally.

This series will help people in having a non-local bookmark workflow involving
remotenames.

The functionality added in this patch is equivalent to --create flag to push
command added by hgremotenames extension.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 15 2018, 9:49 AM
pulkit updated this revision to Diff 7105.Mar 19 2018, 4:36 AM
pulkit updated this revision to Diff 7251.Mar 22 2018, 3:35 AM
pulkit updated this revision to Diff 7288.Mar 26 2018, 7:47 AM
indygreg accepted this revision.Apr 11 2018, 1:35 PM
This revision is now accepted and ready to land.Apr 11 2018, 1:35 PM
marmoute requested changes to this revision.Apr 22 2020, 11:57 AM
marmoute added a subscriber: marmoute.

Baymax does not catch stuff in Accepted state, but this diff is over 2 years old, so resubmit if still relevant.

This revision now requires changes to proceed.Apr 22 2020, 11:57 AM

Revision Contents
Changeset List

PathPackages
Mhgext/remotenames.py (9 lines)
Mtests/test-logexchange.t (54 lines)

Diff 7251

hgext/remotenames.py

namespace (default: 'default') namespace (default: 'default')
remotenames.pushtobookmark remotenames.pushtobookmark
Boolean value to change the behavior of bookmark passed to push command using Boolean value to change the behavior of bookmark passed to push command using
`-B` flag. If set the true, the changesets will be pushed to that bookmark on `-B` flag. If set the true, the changesets will be pushed to that bookmark on
the server. Errors if bookmark does not exists on the server. If multiple the server. Errors if bookmark does not exists on the server. If multiple
bookmarks are specified using `-B` flag, fallbacks to default behavior. bookmarks are specified using `-B` flag, fallbacks to default behavior.
(default: False) (default: False)
remotenames.createremotebookmark
Boolean value indicating whether a creating a new bookmark on the server using
remotenames.pushtobookmark config is allowed or not. (default: False)
""" """
from __future__ import absolute_import from __future__ import absolute_import
from mercurial.i18n import _ from mercurial.i18n import _
from mercurial.node import ( from mercurial.node import (
bin, bin,
default=True, default=True,
) )
configitem('remotenames', 'hoistedpeer', configitem('remotenames', 'hoistedpeer',
default='default', default='default',
) )
configitem('remotenames', 'pushtobookmark', configitem('remotenames', 'pushtobookmark',
default=False, default=False,
) )
configitem('remotenames', 'createremotebookmark',
default=False,
)
def expushdiscoverybookmarks(pushop): def expushdiscoverybookmarks(pushop):
# config not set, fallback to normal push behavior # config not set, fallback to normal push behavior
if not pushop.repo.ui.configbool('remotenames', 'pushtobookmark'): if not pushop.repo.ui.configbool('remotenames', 'pushtobookmark'):
return exchange._pushdiscoverybookmarks(pushop) return exchange._pushdiscoverybookmarks(pushop)
# either zero or more than one bookmarks specified, fallback to normal # either zero or more than one bookmarks specified, fallback to normal
# push behavior, maybe we should error out in case of multiple bookmarks # push behavior, maybe we should error out in case of multiple bookmarks
if len(pushop.bookmarks) != 1: if len(pushop.bookmarks) != 1:
return exchange._pushdiscoverybookmarks(pushop) return exchange._pushdiscoverybookmarks(pushop)
remotemarks = pushop.remote.listkeys('bookmarks') remotemarks = pushop.remote.listkeys('bookmarks')
bookmark = pushop.bookmarks[0] bookmark = pushop.bookmarks[0]
rev = pushop.revs[0] rev = pushop.revs[0]
# allow new bookmark only if --create is specified # allow new bookmark only if --create is specified
old = '' old = ''
if bookmark in remotemarks: if bookmark in remotemarks:
old = remotemarks[bookmark] old = remotemarks[bookmark]
else: elif not pushop.repo.ui.configbool('remotenames', 'createremotebookmark'):
msg = _("bookmark '%s' does not exists on remote") msg = _("bookmark '%s' does not exists on remote")
raise error.Abort(msg % bookmark) raise error.Abort(msg % bookmark)
pushop.outbookmarks.append((bookmark, old, hex(rev))) pushop.outbookmarks.append((bookmark, old, hex(rev)))
class lazyremotenamedict(mutablemapping): class lazyremotenamedict(mutablemapping):
""" """
Read-only dict-like Class to lazily resolve remotename entries Read-only dict-like Class to lazily resolve remotename entries

tests/test-logexchange.t

| date: Thu Jan 01 00:00:00 1970 +0000 | date: Thu Jan 01 00:00:00 1970 +0000
| summary: Added b | summary: Added b
| |
o changeset: 0:18d04c59bb5d o changeset: 0:18d04c59bb5d
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: Added a summary: Added a
Testing the remotenames.createbookmark config option
$ hg bookmarks -R ../server2/
$TESTTMP/server/bar 6:87d6d6676308
$TESTTMP/server/foo 3:62615734edd5
bar 6:87d6d6676308
foo 3:62615734edd5
$ hg push ../server2/ -B nonexistant
pushing to ../server2/
searching for changes
abort: bookmark 'nonexistant' does not exists on remote
[255]
$ hg push ../server2/ -r . -B nonexistant --config remotenames.createremotebookmark=True
pushing to ../server2/
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 1 files
exporting bookmark nonexistant
$ hg bookmarks -R ../server2/
$TESTTMP/server/bar 6:87d6d6676308
$TESTTMP/server/foo 3:62615734edd5
bar 6:87d6d6676308
foo 3:62615734edd5
nonexistant 9:aa6a885086c0
$ hg log -R ../server2/ -r tip
changeset: 9:aa6a885086c0
branch: wat
bookmark: nonexistant
tag: tip
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: added foobar
Check synchornising of remotenames after push
$ hg log -G -r .
@ changeset: 9:aa6a885086c0
| branch: wat
~ tag: tip
remote bookmark: $TESTTMP/server2/nonexistant
remote bookmark: default/foo
hoisted name: foo
remote branch: $TESTTMP/server2/wat
remote branch: default/wat
user: test
date: Thu Jan 01 00:00:00 1970 +0000
summary: added foobar