This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2893

py3: make tests/test-log-linerange.t work on Python 3
ClosedPublic

Authored by pulkit on Mar 19 2018, 3:30 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG0baf0e3ee569: py3: make tests/test-log-linerange.t work on Python 3
Summary

Made sure we write bytes to file and we suppress the return value of open().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 19 2018, 3:30 AM
yuja accepted this revision.Mar 19 2018, 9:34 AM
This revision is now accepted and ready to land.Mar 19 2018, 9:34 AM
Closed by commit rHG0baf0e3ee569: py3: make tests/test-log-linerange.t work on Python 3 (authored by pulkit). · Explain WhyMar 19 2018, 9:46 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-log-linerange.t (2 lines)

Diff 7111

tests/test-log-linerange.t

+2 +2
+3 +3
+4 +4
Binary files work but without diff hunks filtering. Binary files work but without diff hunks filtering.
(Checking w/ and w/o diff.git option.) (Checking w/ and w/o diff.git option.)
>>> open('binary', 'wb').write('this\nis\na\nbinary\0') >>> open('binary', 'wb').write(b'this\nis\na\nbinary\0') and None
$ hg add binary $ hg add binary
$ hg ci -m 'add a binary file' --quiet $ hg ci -m 'add a binary file' --quiet
$ hg log -f -L binary,1:2 -p $ hg log -f -L binary,1:2 -p
changeset: 10:c96381c229df changeset: 10:c96381c229df
tag: tip tag: tip
user: test user: test
date: Thu Jan 01 00:00:00 1970 +0000 date: Thu Jan 01 00:00:00 1970 +0000
summary: add a binary file summary: add a binary file