This is an archive of the discontinued Mercurial Phabricator instance.

Differential D291

repair: refactor broken linkrev collection
ClosedPublic

Authored by durham on Aug 8 2017, 8:33 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG6626d12e7a85: repair: refactor broken linkrev collection
Summary

This refactors broken linkrev collection such that manifest collection is in a
separate function. This allows extensions to replace the manifest collection
with a non-revlog oriented version.

I considered moving the collect changes function onto the manifestlog itself, so
it would be behind the abstraction, but since the store we're building doesn't
even have the concept of strip, embeding that concept in the manifestlog api
seemed odd.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durham created this revision.Aug 8 2017, 8:33 PM
Closed by commit rHG6626d12e7a85: repair: refactor broken linkrev collection (authored by durham). · Explain WhyAug 9 2017, 11:36 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/repair.py (14 lines)

Diff 692

mercurial/repair.py

"""find out the filelogs affected by the strip""" """find out the filelogs affected by the strip"""
files = set() files = set()
for x in xrange(striprev, len(repo)): for x in xrange(striprev, len(repo)):
files.update(repo[x].files()) files.update(repo[x].files())
return sorted(files) return sorted(files)
def _collectrevlog(revlog, striprev):
_, brokenset = revlog.getstrippoint(striprev)
return [revlog.linkrev(r) for r in brokenset]
def _collectmanifest(repo, striprev):
return _collectrevlog(repo.manifestlog._revlog, striprev)
def _collectbrokencsets(repo, files, striprev): def _collectbrokencsets(repo, files, striprev):
"""return the changesets which will be broken by the truncation""" """return the changesets which will be broken by the truncation"""
s = set() s = set()
def collectone(revlog):
_, brokenset = revlog.getstrippoint(striprev)
s.update([revlog.linkrev(r) for r in brokenset])
collectone(repo.manifestlog._revlog) s.update(_collectmanifest(repo, striprev))
for fname in files: for fname in files:
collectone(repo.file(fname)) s.update(_collectrevlog(repo.file(fname), striprev))
return s return s
def strip(ui, repo, nodelist, backup=True, topic='backup'): def strip(ui, repo, nodelist, backup=True, topic='backup'):
# This function requires the caller to lock the repo, but it operates # This function requires the caller to lock the repo, but it operates
# within a transaction of its own, and thus requires there to be no current # within a transaction of its own, and thus requires there to be no current
# transaction when it is called. # transaction when it is called.
if repo.currenttransaction() is not None: if repo.currenttransaction() is not None: