( )⚙ D2961 locate: avoid using "rev" variable name for nodeid

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2961

locate: avoid using "rev" variable name for nodeid
ClosedPublic

Authored by martinvonz on Mar 28 2018, 6:49 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGeb4a23382e18: locate: avoid using "rev" variable name for nodeid
Summary

Also, drop silly "ctx = repo[ctx.node()]".

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 28 2018, 6:49 PM
indygreg accepted this revision.Mar 28 2018, 7:23 PM
This revision is now accepted and ready to land.Mar 28 2018, 7:23 PM
Closed by commit rHGeb4a23382e18: locate: avoid using "rev" variable name for nodeid (authored by martinvonz). · Explain WhyMar 28 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (3 lines)

Diff 7356

mercurial/commands.py

Returns 0 if a match is found, 1 otherwise. Returns 0 if a match is found, 1 otherwise.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
if opts.get('print0'): if opts.get('print0'):
end = '\0' end = '\0'
else: else:
end = '\n' end = '\n'
rev = scmutil.revsingle(repo, opts.get('rev'), None).node() ctx = scmutil.revsingle(repo, opts.get('rev'), None)
ret = 1 ret = 1
ctx = repo[rev]
m = scmutil.match(ctx, pats, opts, default='relglob', m = scmutil.match(ctx, pats, opts, default='relglob',
badfn=lambda x, y: False) badfn=lambda x, y: False)
ui.pager('locate') ui.pager('locate')
for abs in ctx.matches(m): for abs in ctx.matches(m):
if opts.get('fullpath'): if opts.get('fullpath'):
ui.write(repo.wjoin(abs), end) ui.write(repo.wjoin(abs), end)
else: else: