This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2974

contrib: rename clang-format-blacklist to clang-format-ignorelist
ClosedPublic

Authored by indygreg on Mar 30 2018, 2:36 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG0024961aa493: contrib: rename clang-format-blacklist to clang-format-ignorelist
Summary

"blacklist" is racially charged. Let's rename it to something
that isn't.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Mar 30 2018, 2:36 PM
pulkit accepted this revision.Mar 30 2018, 2:56 PM
Closed by commit rHG0024961aa493: contrib: rename clang-format-blacklist to clang-format-ignorelist (authored by indygreg). · Explain WhyMar 30 2018, 3:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 7404

Makefile

$(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python ) $(MAKE) -f $(HGROOT)/contrib/Makefile.python PYTHONVER=$* PREFIX=$(HGPYTHONS)/$* python )
cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS) cd tests && $(HGPYTHONS)/$*/bin/python run-tests.py $(TESTFLAGS)
check-code: check-code:
hg manifest | xargs python contrib/check-code.py hg manifest | xargs python contrib/check-code.py
format-c: format-c:
clang-format --style file -i \ clang-format --style file -i \
`hg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-blacklist"'` `hg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-ignorelist"'`
update-pot: i18n/hg.pot update-pot: i18n/hg.pot
i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext i18n/hg.pot: $(PYFILES) $(DOCFILES) i18n/posplit i18n/hggettext
$(PYTHON) i18n/hggettext mercurial/commands.py \ $(PYTHON) i18n/hggettext mercurial/commands.py \
hgext/*.py hgext/*/__init__.py \ hgext/*.py hgext/*/__init__.py \
mercurial/fileset.py mercurial/revset.py \ mercurial/fileset.py mercurial/revset.py \
mercurial/templatefilters.py \ mercurial/templatefilters.py \

contrib/clang-format-blacklist

  • This file was moved to contrib/clang-format-ignorelist.

contrib/clang-format-ignorelist

  • This file was moved from contrib/clang-format-blacklist.

tests/test-check-clang-format.t

#require clang-format test-repo #require clang-format test-repo
$ . "$TESTDIR/helpers-testrepo.sh" $ . "$TESTDIR/helpers-testrepo.sh"
$ cd "$TESTDIR"/.. $ cd "$TESTDIR"/..
$ for f in `testrepohg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-blacklist"'` ; do $ for f in `testrepohg files 'set:(**.c or **.cc or **.h) and not "listfile:contrib/clang-format-ignorelist"'` ; do
> clang-format --style file $f > $f.formatted > clang-format --style file $f > $f.formatted
> cmp $f $f.formatted || diff -u $f $f.formatted > cmp $f $f.formatted || diff -u $f $f.formatted
> rm $f.formatted > rm $f.formatted
> done > done