( )⚙ D2996 bundle2: make source a mandatory argument for bundle2.applybundle() (API)

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2996

bundle2: make source a mandatory argument for bundle2.applybundle() (API)
ClosedPublic

Authored by pulkit on Mar 31 2018, 6:24 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG684a6a261f30: bundle2: make source a mandatory argument for bundle2.applybundle() (API)
Summary

Currently all the callers in the core pass the source argument, making it
mandatory will help us storing right source value in bundleoperation() class.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Mar 31 2018, 6:24 AM
indygreg accepted this revision.Mar 31 2018, 1:16 PM
This revision is now accepted and ready to land.Mar 31 2018, 1:16 PM
Closed by commit rHG684a6a261f30: bundle2: make source a mandatory argument for bundle2.applybundle() (API) (authored by pulkit). · Explain WhyMar 31 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/bundle2.py (2 lines)

Diff 7474

mercurial/bundle2.py

def _notransaction(): def _notransaction():
"""default method to get a transaction while processing a bundle """default method to get a transaction while processing a bundle
Raise an exception to highlight the fact that no transaction was expected Raise an exception to highlight the fact that no transaction was expected
to be created""" to be created"""
raise TransactionUnavailable() raise TransactionUnavailable()
def applybundle(repo, unbundler, tr, source=None, url=None, **kwargs): def applybundle(repo, unbundler, tr, source, url=None, **kwargs):
# transform me into unbundler.apply() as soon as the freeze is lifted # transform me into unbundler.apply() as soon as the freeze is lifted
if isinstance(unbundler, unbundle20): if isinstance(unbundler, unbundle20):
tr.hookargs['bundle2'] = '1' tr.hookargs['bundle2'] = '1'
if source is not None and 'source' not in tr.hookargs: if source is not None and 'source' not in tr.hookargs:
tr.hookargs['source'] = source tr.hookargs['source'] = source
if url is not None and 'url' not in tr.hookargs: if url is not None and 'url' not in tr.hookargs:
tr.hookargs['url'] = url tr.hookargs['url'] = url
return processbundle(repo, unbundler, lambda: tr, source=source) return processbundle(repo, unbundler, lambda: tr, source=source)