( )⚙ D2997 infinitepush: use bundleoperation.source instead of hacking on tr

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D2997

infinitepush: use bundleoperation.source instead of hacking on tr
ClosedPublic

Authored by pulkit on Mar 31 2018, 6:24 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG40ee0af04e3a: infinitepush: use bundleoperation.source instead of hacking on tr
Summary

Previous patches added a soutce attribute to bundle2.bundleoperation class which
stores the command which leads to current bundleoperation. Let's use that to
decide whether a processing a hg unbundle or not instead of hacking on
transaction.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Mar 31 2018, 6:24 AM
indygreg accepted this revision.Mar 31 2018, 1:16 PM
This revision is now accepted and ready to land.Mar 31 2018, 1:16 PM
Closed by commit rHG40ee0af04e3a: infinitepush: use bundleoperation.source instead of hacking on tr (authored by pulkit). · Explain WhyMar 31 2018, 1:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/infinitepush/__init__.py (6 lines)

Diff 7464

hgext/infinitepush/__init__.py

os.unlink(bundlefile) os.unlink(bundlefile)
except Exception: except Exception:
# we would rather see the original exception # we would rather see the original exception
pass pass
def processparts(orig, repo, op, unbundler): def processparts(orig, repo, op, unbundler):
# make sure we don't wrap processparts in case of `hg unbundle` # make sure we don't wrap processparts in case of `hg unbundle`
tr = repo.currenttransaction() if op.source == 'unbundle':
if tr:
if tr.names[0].startswith('unbundle'):
return orig(repo, op, unbundler) return orig(repo, op, unbundler)
# this server routes each push to bundle store # this server routes each push to bundle store
if repo.ui.configbool('infinitepush', 'pushtobundlestore'): if repo.ui.configbool('infinitepush', 'pushtobundlestore'):
return storetobundlestore(orig, repo, op, unbundler) return storetobundlestore(orig, repo, op, unbundler)
if unbundler.params.get('infinitepush') != 'True': if unbundler.params.get('infinitepush') != 'True':
return orig(repo, op, unbundler) return orig(repo, op, unbundler)