This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3037

repo: remove now-unused changectx() method (API)
ClosedPublic

Authored by martinvonz on Apr 3 2018, 12:14 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG836867586b83: repo: remove now-unused changectx() method (API)
Summary

repo.changectx(x) was just a synonym for repo[x], so any extensions
that fail due to this commit should switch over to that form.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Apr 3 2018, 12:14 PM
pulkit added a subscriber: pulkit.Apr 3 2018, 2:21 PM

I know it's pretty obvious to us that repo.getitem should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some time can be saved.

martinvonz edited the summary of this revision. (Show Details)Apr 3 2018, 4:19 PM
martinvonz added a comment.Apr 3 2018, 4:20 PM
In D3037#49157, @pulkit wrote:

I know it's pretty obvious to us that repo.getitem should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some time can be saved.

Makes sense. Done.

pulkit accepted this revision.Apr 4 2018, 6:43 AM
Closed by commit rHG836867586b83: repo: remove now-unused changectx() method (API) (authored by martinvonz). · Explain WhyApr 4 2018, 7:21 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (3 lines)
Mmercurial/repository.py (6 lines)

Diff 7542

mercurial/localrepo.py

def wjoin(self, f, *insidef): def wjoin(self, f, *insidef):
return self.vfs.reljoin(self.root, f, *insidef) return self.vfs.reljoin(self.root, f, *insidef)
def file(self, f): def file(self, f):
if f[0] == '/': if f[0] == '/':
f = f[1:] f = f[1:]
return filelog.filelog(self.svfs, f) return filelog.filelog(self.svfs, f)
def changectx(self, changeid):
return self[changeid]
def setparents(self, p1, p2=nullid): def setparents(self, p1, p2=nullid):
with self.dirstate.parentchange(): with self.dirstate.parentchange():
copies = self.dirstate.setparents(p1, p2) copies = self.dirstate.setparents(p1, p2)
pctx = self[p1] pctx = self[p1]
if copies: if copies:
# Adjust copy records, the dirstate cannot do it, it # Adjust copy records, the dirstate cannot do it, it
# requires access to parents manifests. Preserve them # requires access to parents manifests. Preserve them
# only for entries added to first parent. # only for entries added to first parent.

mercurial/repository.py

"""The type of shared repository or None.""" """The type of shared repository or None."""
def wjoin(f, *insidef): def wjoin(f, *insidef):
"""Calls self.vfs.reljoin(self.root, f, *insidef)""" """Calls self.vfs.reljoin(self.root, f, *insidef)"""
def file(f): def file(f):
"""Obtain a filelog for a tracked path.""" """Obtain a filelog for a tracked path."""
def changectx(changeid):
"""Obtains a changectx for a revision.
Identical to __getitem__.
"""
def setparents(p1, p2): def setparents(p1, p2):
"""Set the parent nodes of the working directory.""" """Set the parent nodes of the working directory."""
def filectx(path, changeid=None, fileid=None): def filectx(path, changeid=None, fileid=None):
"""Obtain a filectx for the given file revision.""" """Obtain a filectx for the given file revision."""
def getcwd(): def getcwd():
"""Obtain the current working directory from the dirstate.""" """Obtain the current working directory from the dirstate."""