This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3052

bisect: avoid repo.lookup() for converting revnum to nodeid
ClosedPublic

Authored by martinvonz on Apr 3 2018, 6:08 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHGe47bd4c71c5e: bisect: avoid repo.lookup() for converting revnum to nodeid
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Apr 3 2018, 6:08 PM
indygreg accepted this revision.Apr 3 2018, 7:14 PM
This revision is now accepted and ready to land.Apr 3 2018, 7:14 PM
Closed by commit rHGe47bd4c71c5e: bisect: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz). · Explain WhyApr 3 2018, 7:24 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)

Diff 7592

mercurial/commands.py

hbisect.resetstate(repo) hbisect.resetstate(repo)
return return
state = hbisect.load_state(repo) state = hbisect.load_state(repo)
# update state # update state
if good or bad or skip: if good or bad or skip:
if rev: if rev:
nodes = [repo.lookup(i) for i in scmutil.revrange(repo, [rev])] nodes = [repo[i].node() for i in scmutil.revrange(repo, [rev])]
else: else:
nodes = [repo.lookup('.')] nodes = [repo.lookup('.')]
if good: if good:
state['good'] += nodes state['good'] += nodes
elif bad: elif bad:
state['bad'] += nodes state['bad'] += nodes
elif skip: elif skip:
state['skip'] += nodes state['skip'] += nodes