This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3072

tests: add tests showing pulling from infinitepush works over wire
ClosedPublic

Authored by pulkit on Apr 4 2018, 8:27 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG8478b198af9c: tests: add tests showing pulling from infinitepush works over wire
Summary

The current tests in test-infinitepush-ci.t showed that hg pull -r <rev> does
not work. Digging in code, I found that we have logic for pulling from
bundlestore without having client side logic. This patch adds test demonstrating
that pulling from bundlestore works when working over wire.
Pulling from bundlestore when the peer is a localpeer still does not works.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Apr 4 2018, 8:27 AM
durin42 accepted this revision.Apr 11 2018, 1:21 PM
This revision is now accepted and ready to land.Apr 11 2018, 1:21 PM
Closed by commit rHG8478b198af9c: tests: add tests showing pulling from infinitepush works over wire (authored by pulkit). · Explain WhyApr 11 2018, 1:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-infinitepush-ci.t (67 lines)

Diff 7616

tests/test-infinitepush-ci.t

Testing the case when there is no infinitepush extension present on the client Testing the case when there is no infinitepush extension present on the client
side and the server routes each push to bundlestore. This case is very much side and the server routes each push to bundlestore. This case is very much
similar to CI use case. similar to CI use case.
Setup Setup
----- -----
$ . "$TESTDIR/library-infinitepush.sh" $ . "$TESTDIR/library-infinitepush.sh"
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [ui]
> ssh = python "$TESTDIR/dummyssh"
> [alias] > [alias]
> glog = log -GT "{rev}:{node|short} {desc}\n{phase}" > glog = log -GT "{rev}:{node|short} {desc}\n{phase}"
> EOF > EOF
$ cp $HGRCPATH $TESTTMP/defaulthgrc $ cp $HGRCPATH $TESTTMP/defaulthgrc
$ hg init repo $ hg init repo
$ cd repo $ cd repo
$ setupserver $ setupserver
$ echo "pushtobundlestore = True" >> .hg/hgrc $ echo "pushtobundlestore = True" >> .hg/hgrc
$ echo "[extensions]" >> .hg/hgrc $ echo "[extensions]" >> .hg/hgrc
$ echo "infinitepush=" >> .hg/hgrc $ echo "infinitepush=" >> .hg/hgrc
$ echo initialcommit > initialcommit $ echo initialcommit > initialcommit
$ hg ci -Aqm "initialcommit" $ hg ci -Aqm "initialcommit"
$ hg phase --public . $ hg phase --public .
$ cd .. $ cd ..
$ hg clone repo client -q $ hg clone repo client -q
$ hg clone repo client2 -q $ hg clone repo client2 -q
$ hg clone ssh://user@dummy/repo client3 -q
$ cd client $ cd client
Pushing a new commit from the client to the server Pushing a new commit from the client to the server
----------------------------------------------------- -----------------------------------------------------
$ echo foobar > a $ echo foobar > a
$ hg ci -Aqm "added a" $ hg ci -Aqm "added a"
$ hg glog $ hg glog
no changes found no changes found
[1] [1]
$ hg pull $ hg pull
pulling from $TESTTMP/repo pulling from $TESTTMP/repo
searching for changes searching for changes
no changes found no changes found
Pulling from second client to test `hg pull -r <rev>` Pulling from second client which is a localpeer to test `hg pull -r <rev>`
------------------------------------------------------ --------------------------------------------------------------------------
Pulling the revision which is applied Pulling the revision which is applied
$ cd ../client2 $ cd ../client2
$ hg pull -r 6cb0989601f1 $ hg pull -r 6cb0989601f1
pulling from $TESTTMP/repo pulling from $TESTTMP/repo
searching for changes searching for changes
adding changesets adding changesets
adding manifests adding manifests
adding file changes adding file changes
added 1 changesets with 1 changes to 1 files added 1 changesets with 1 changes to 1 files
new changesets 6cb0989601f1 new changesets 6cb0989601f1
(run 'hg update' to get a working copy) (run 'hg update' to get a working copy)
$ hg glog $ hg glog
o 1:6cb0989601f1 added a o 1:6cb0989601f1 added a
| public | public
@ 0:67145f466344 initialcommit @ 0:67145f466344 initialcommit
public public
Pulling the revision which is in bundlestore Pulling the revision which is in bundlestore
XXX: we should support pulling revisions from bundlestore without client side XXX: we should support pulling revisions from a local peers bundlestore without
wrapping client side wrapping
$ hg pull -r b4e4bce660512ad3e71189e14588a70ac8e31fef $ hg pull -r b4e4bce660512ad3e71189e14588a70ac8e31fef
pulling from $TESTTMP/repo pulling from $TESTTMP/repo
abort: unknown revision 'b4e4bce660512ad3e71189e14588a70ac8e31fef'! abort: unknown revision 'b4e4bce660512ad3e71189e14588a70ac8e31fef'!
[255] [255]
$ hg glog $ hg glog
o 1:6cb0989601f1 added a o 1:6cb0989601f1 added a
| public | public
@ 0:67145f466344 initialcommit @ 0:67145f466344 initialcommit
public public
$ cd ../client $ cd ../client
Pulling from third client which is not a localpeer
---------------------------------------------------
Pulling the revision which is applied
$ cd ../client3
$ hg pull -r 6cb0989601f1
pulling from ssh://user@dummy/repo
searching for changes
adding changesets
adding manifests
adding file changes
added 1 changesets with 1 changes to 1 files
new changesets 6cb0989601f1
(run 'hg update' to get a working copy)
$ hg glog
o 1:6cb0989601f1 added a
| public
@ 0:67145f466344 initialcommit
public
Pulling the revision which is in bundlestore
Trying to specify short hash
XXX: we should support this
$ hg pull -r b4e4bce660512
pulling from ssh://user@dummy/repo
abort: unknown revision 'b4e4bce660512'!
[255]
XXX: we should show better message when the pull is happening from bundlestore
$ hg pull -r b4e4bce660512ad3e71189e14588a70ac8e31fef
pulling from ssh://user@dummy/repo
searching for changes
no changes found
adding changesets
adding manifests
adding file changes
added 4 changesets with 4 changes to 4 files
new changesets eaba929e866c:b4e4bce66051
$ hg glog
o 5:b4e4bce66051 added e
| public
o 4:1bb96358eda2 added d
| public
o 3:bf8a6e3011b3 added c
| public
o 2:eaba929e866c added b
| public
o 1:6cb0989601f1 added a
| public
@ 0:67145f466344 initialcommit
public
$ cd ../client
Checking storage of phase information with the bundle on bundlestore Checking storage of phase information with the bundle on bundlestore
--------------------------------------------------------------------- ---------------------------------------------------------------------
creating a draft commit creating a draft commit
$ cat >> $HGRCPATH <<EOF $ cat >> $HGRCPATH <<EOF
> [phases] > [phases]
> publish = False > publish = False
> EOF > EOF