This is an archive of the discontinued Mercurial Phabricator instance.

py3: use list comprehension instead of map()
AbandonedPublic

Authored by pulkit on Apr 5 2018, 8:30 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Summary

map() on Python 3 returns a map object not a list, so let's use list
comprehension where we require list.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.Apr 5 2018, 8:30 AM
yuja requested changes to this revision.Apr 5 2018, 9:43 AM
yuja added a subscriber: yuja.

That shouldn't matter here because bytes.join() takes an iterable.

This revision now requires changes to proceed.Apr 5 2018, 9:43 AM
pulkit abandoned this revision.Apr 5 2018, 2:58 PM