( )⚙ D3152 upgrade: sniff for filelog type

This is an archive of the discontinued Mercurial Phabricator instance.

upgrade: sniff for filelog type
ClosedPublic

Authored by indygreg on Apr 5 2018, 8:51 PM.

Details

Summary

The upgrade code should never encounter a vanilla revlog
instance: only changelog, manifestrevlog, and filelog should
be seen.

The previous code assumed !changelog & !manifestrevlog meant
file data. So this change feels pretty safe. If nothing else, it
will help tease out typing issues.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 5 2018, 8:51 PM
durin42 accepted this revision.Apr 6 2018, 8:59 PM
This revision is now accepted and ready to land.Apr 6 2018, 8:59 PM
This revision was automatically updated to reflect the committed changes.