This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: send server capabilities in canonical order
ClosedPublic

Authored by joerg.sonnenberger on Apr 6 2018, 5:39 PM.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg accepted this revision.Apr 6 2018, 6:06 PM
indygreg added a subscriber: indygreg.

THANK YOU for this cleanup. The wonky ordering due to the way capabilities are added on the server has annoyed me too.

As part of reviewing this, it is more obvious than before that $USUAL_BUNDLE2_CAPS_SERVER$ should probably be loosened so it doesn't include the bundle2= prefix. That would make it clear that it belongs at this position in the list.

This revision is now accepted and ready to land.Apr 6 2018, 6:06 PM
This revision was automatically updated to reflect the committed changes.