This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3183

wireproto: only expose "hello" command to version 1 transports
ClosedPublic

Authored by indygreg on Apr 7 2018, 1:53 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG6e6d68c2d39c: wireproto: only expose "hello" command to version 1 transports
Summary

This command is only ever used for the handshake in the SSH protocol.
We probably don't even need for it to be a proper command. Let's not
carry it forward to version 2 because I don't see a use for it there.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 7 2018, 1:53 AM
yuja accepted this revision.Apr 9 2018, 10:58 AM
This revision is now accepted and ready to land.Apr 9 2018, 10:58 AM
Closed by commit rHG6e6d68c2d39c: wireproto: only expose "hello" command to version 1 transports (authored by indygreg). · Explain WhyApr 9 2018, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireproto.py (2 lines)

Diff 7868

mercurial/wireproto.py

return wireprototypes.streamres( return wireprototypes.streamres(
gen=chunks, prefer_uncompressed=not prefercompressed) gen=chunks, prefer_uncompressed=not prefercompressed)
@wireprotocommand('heads', permission='pull', transportpolicy=POLICY_V1_ONLY) @wireprotocommand('heads', permission='pull', transportpolicy=POLICY_V1_ONLY)
def heads(repo, proto): def heads(repo, proto):
h = repo.heads() h = repo.heads()
return wireprototypes.bytesresponse(encodelist(h) + '\n') return wireprototypes.bytesresponse(encodelist(h) + '\n')
@wireprotocommand('hello', permission='pull') @wireprotocommand('hello', permission='pull', transportpolicy=POLICY_V1_ONLY)
def hello(repo, proto): def hello(repo, proto):
"""Called as part of SSH handshake to obtain server info. """Called as part of SSH handshake to obtain server info.
Returns a list of lines describing interesting things about the Returns a list of lines describing interesting things about the
server, in an RFC822-like format. server, in an RFC822-like format.
Currently, the only one defined is ``capabilities``, which consists of a Currently, the only one defined is ``capabilities``, which consists of a
line of space separated tokens describing server abilities: line of space separated tokens describing server abilities: