( )⚙ D3184 wireproto: only expose "debugwireargs" to version 1 transports

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3184

wireproto: only expose "debugwireargs" to version 1 transports
ClosedPublic

Authored by indygreg on Apr 7 2018, 1:53 AM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG3a91911c4343: wireproto: only expose "debugwireargs" to version 1 transports
Summary

I'm not even sure this command should be enabled for version 1
transports. It is just a reflection endpoint for argument data.
We definitely don't need to support it in version 2.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 7 2018, 1:53 AM
yuja accepted this revision.Apr 9 2018, 10:58 AM
This revision is now accepted and ready to land.Apr 9 2018, 10:58 AM
Closed by commit rHG3a91911c4343: wireproto: only expose "debugwireargs" to version 1 transports (authored by indygreg). · Explain WhyApr 9 2018, 11:14 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/wireproto.py (2 lines)

Diff 7869

mercurial/wireproto.py

heads = decodelist(heads) heads = decodelist(heads)
outgoing = discovery.outgoing(repo, missingroots=bases, outgoing = discovery.outgoing(repo, missingroots=bases,
missingheads=heads) missingheads=heads)
cg = changegroupmod.makechangegroup(repo, outgoing, '01', 'serve') cg = changegroupmod.makechangegroup(repo, outgoing, '01', 'serve')
gen = iter(lambda: cg.read(32768), '') gen = iter(lambda: cg.read(32768), '')
return wireprototypes.streamres(gen=gen) return wireprototypes.streamres(gen=gen)
@wireprotocommand('debugwireargs', 'one two *', @wireprotocommand('debugwireargs', 'one two *',
permission='pull') permission='pull', transportpolicy=POLICY_V1_ONLY)
def debugwireargs(repo, proto, one, two, others): def debugwireargs(repo, proto, one, two, others):
# only accept optional args from the known set # only accept optional args from the known set
opts = options('debugwireargs', ['three', 'four'], others) opts = options('debugwireargs', ['three', 'four'], others)
return wireprototypes.bytesresponse(repo.debugwireargs( return wireprototypes.bytesresponse(repo.debugwireargs(
one, two, **pycompat.strkwargs(opts))) one, two, **pycompat.strkwargs(opts)))
@wireprotocommand('getbundle', '*', permission='pull') @wireprotocommand('getbundle', '*', permission='pull')
def getbundle(repo, proto, others): def getbundle(repo, proto, others):