This is an archive of the discontinued Mercurial Phabricator instance.

httppeer: extract code for creating a request into own function
ClosedPublic

Authored by indygreg on Apr 10 2018, 9:28 PM.

Details

Summary

Some of this feels awkward, such as having to pass in a function
to evaluate a capability. And this code is generally pretty difficult
to read. I didn't want to perform too much refactoring as part of
the code move since it would make review more difficult.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 10 2018, 9:28 PM
durin42 accepted this revision.Apr 11 2018, 12:45 PM
This revision is now accepted and ready to land.Apr 11 2018, 12:45 PM
This revision was automatically updated to reflect the committed changes.