This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3247

tests: load showstack in test-pull-http.t so network hangs are easier to find
ClosedPublic

Authored by durin42 on Apr 11 2018, 3:50 PM.

Download Raw Diff

Details

Reviewers

indygreg

Group Reviewers

hg-reviewers

Commits

rHG165a77f7ec13: tests: load showstack in test-pull-http.t so network hangs are easier to find

Summary

This also gives us some minimal "it loads" coverage on showstack,
which I rather like. showstack doesn't work on Windows per mbarbison,
so it's disabled there.

I added this in service of debugging a hang introduced on Python 3 by
revision a88d68dc3ee8. I'm still not sure what the problem there is,
but this at least gives us a little bit of a chance to figure out
what's going on.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 11 2018, 3:50 PM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptApr 11 2018, 3:50 PM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

durin42 added a child revision: D3248: hgweb: put response headers back into str for Python 3.Apr 11 2018, 4:10 PM

It doesn't load on Windows:

$ ../hg id --config extensions.showstack=../contrib/showstack.py --config extensions.evolve=!
Traceback (most recent call last):
  File "e:\Projects\hg\mercurial\extensions.py", line 215, in _runextsetup
    extsetup(ui)
  File "../contrib/showstack.py", line 18, in extsetup
    signal.signal(signal.SIGQUIT, sigshow)
AttributeError: 'module' object has no attribute 'SIGQUIT'
*** failed to set up extension showstack: 'module' object has no attribute 'SIGQUIT'

durin42 edited the summary of this revision. (Show Details)Apr 12 2018, 11:03 AM

durin42 updated this revision to Diff 8053.

In D3247#52450, @mharbison72 wrote:

It doesn't load on Windows:

$ ../hg id --config extensions.showstack=../contrib/showstack.py --config extensions.evolve=!
Traceback (most recent call last):
  File "e:\Projects\hg\mercurial\extensions.py", line 215, in _runextsetup
    extsetup(ui)
  File "../contrib/showstack.py", line 18, in extsetup
    signal.signal(signal.SIGQUIT, sigshow)
AttributeError: 'module' object has no attribute 'SIGQUIT'
*** failed to set up extension showstack: 'module' object has no attribute 'SIGQUIT'

I should have known. Now guarded by a no-windows.

indygreg accepted this revision.Apr 12 2018, 11:15 AM

This revision is now accepted and ready to land.Apr 12 2018, 11:15 AM

Closed by commit rHG165a77f7ec13: tests: load showstack in test-pull-http.t so network hangs are easier to find (authored by durin42). · Explain WhyApr 12 2018, 11:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-pull-http.t (11 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	8011		Apr 11 2018, 3:50 PM	★	★
Diff 2	8053		Apr 12 2018, 11:03 AM	★	★
Diff 3	8066	rHG165a77f7ec132170d47d0728384607b9c48dbd64	Apr 11 2018, 2:57 PM	★	★

Status	Author	Revision
Closed	durin42	D3253 py3: whitelist another nine passing tests
Closed	durin42	D3251 tests: glob away fqdn wherever we print it
Closed	durin42	D3250 hgweb: use native strings when interfacing with stdlib headers
Closed	durin42	D3249 wireprotoserver: headers are bytes for us internally, use bytes
Closed	durin42	D3248 hgweb: put response headers back into str for Python 3
Closed	durin42	D3247 tests: load showstack in test-pull-http.t so network hangs are easier to find
Closed	durin42	D3246 keepalive: rewrite readinto() to not use read()
Closed	durin42	D2854 hgweb: use our forked wsgiheaders module instead of stdlib one
Closed	durin42	D2853 tests: add a cat of `error.log` in subrepo test
Closed	durin42	D2846 hghave: fix hardlink-whitelisted check on Python 3
Closed	durin42	D2845 hghave: fix xdiff check on Python 3
Closed	durin42	D2844 commandserver: prefer first-party selectors module from Python 3 to backport
Closed	durin42	D3245 wsgiheaders: import a bytes-ified fork of wsgiref.headers from cpython@46f5072

Diff 8066

tests/test-pull-http.t

	#require killdaemons			#require killdaemons

				#if no-windows
				For debugging: this is a pretty simple test that is a good candidate
				for tracking down network-related bugs. Sometimes a command in this
				hangs, so having showstack pre-loaded is sometimes helpful. This also
				gives us a test that at least proves showstack can be loaded.
				$ cat >> $HGRCPATH <<EOF
				> [extensions]
				> showstack = $TESTDIR/../contrib/showstack.py
				> EOF
				#endif

	$ hg init test			$ hg init test
	$ cd test			$ cd test
	$ echo a > a			$ echo a > a
	$ hg ci -Ama			$ hg ci -Ama
	adding a			adding a
	$ cd ..			$ cd ..
	$ hg clone test test2			$ hg clone test test2
	updating to branch default			updating to branch default