This is an archive of the discontinued Mercurial Phabricator instance.

In D3283#52480, @indygreg wrote:

Nit: (I've seen a few commit messages with this mistake.) The thing whose return is being suppressed is .write() not open().

If you can fix the commit message on flight, please do. I will take care of this next time.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-subrepo-missing.t (4 lines)

Status	Author	Revision
Closed	pulkit	D3285 py3: use bytes() instead of str() on util.url()
Closed	pulkit	D3284 py3: use stringutil.forcebytestr() to convert error messages to bytes
Closed	pulkit	D3283 py3: suppress the return value of open() in tests/test-subrepo-missing.t
Closed	pulkit	D3282 py3: add b'' prefixes in tests/test-linerange.py
Closed	pulkit	D3281 py3: add b'' prefix to make the regex bytes
Closed	pulkit	D3280 py3: use b'%d' to convert int to bytes instead of str()
Closed	pulkit	D3279 py3: make sure decode() first argument is str
Closed	pulkit	D3278 py3: use print as a function in test-convert-git.t
Closed	pulkit	D3277 py3: use '%d' for integers instead of '%s'
Closed	pulkit	D3276 py3: prevent transformer from adding b'' by adding r'' prefix
Closed	pulkit	D3275 py3: use pycompat.{strkwargs\|byteskwargs} in infinitepush
Closed	pulkit	D3274 py3: make sure we open file in bytes mode

Diff 8062

tests/test-subrepo-missing.t

	$ hg init repo			$ hg init repo
	$ cd repo			$ cd repo
	$ hg init subrepo			$ hg init subrepo
	$ echo a > subrepo/a			$ echo a > subrepo/a
	$ hg -R subrepo ci -Am adda			$ hg -R subrepo ci -Am adda
	adding a			adding a
	$ echo 'subrepo = subrepo' > .hgsub			$ echo 'subrepo = subrepo' > .hgsub
	$ hg ci -Am addsubrepo			$ hg ci -Am addsubrepo
	adding .hgsub			adding .hgsub
	$ echo b > subrepo/b			$ echo b > subrepo/b
	$ hg -R subrepo ci -Am addb			$ hg -R subrepo ci -Am addb
	adding b			adding b
	$ hg ci -m updatedsub			$ hg ci -m updatedsub

	ignore blanklines in .hgsubstate			ignore blanklines in .hgsubstate

	>>> open('.hgsubstate', 'wb').write(b'\n\n \t \n \n')			>>> open('.hgsubstate', 'wb').write(b'\n\n \t \n \n') and None
	$ hg st --subrepos			$ hg st --subrepos
	M .hgsubstate			M .hgsubstate
	$ hg revert -qC .hgsubstate			$ hg revert -qC .hgsubstate

	abort more gracefully on .hgsubstate parsing error			abort more gracefully on .hgsubstate parsing error

	$ cp .hgsubstate .hgsubstate.old			$ cp .hgsubstate .hgsubstate.old
	>>> open('.hgsubstate', 'wb').write(b'\ninvalid')			>>> open('.hgsubstate', 'wb').write(b'\ninvalid') and None
	$ hg st --subrepos --cwd $TESTTMP -R $TESTTMP/repo			$ hg st --subrepos --cwd $TESTTMP -R $TESTTMP/repo
	abort: invalid subrepository revision specifier in 'repo/.hgsubstate' line 2			abort: invalid subrepository revision specifier in 'repo/.hgsubstate' line 2
	[255]			[255]
	$ mv .hgsubstate.old .hgsubstate			$ mv .hgsubstate.old .hgsubstate

	delete .hgsub and revert it			delete .hgsub and revert it

	$ rm .hgsub			$ rm .hgsub

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	8050		Apr 12 2018, 8:07 AM	★	★
Diff 2	8062	rHGfd0e6678ba0ff6925b272fef2b97c98011e93cf1	Apr 12 2018, 11:06 AM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

py3: suppress the return value of open() in tests/test-subrepo-missing.tClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8062

tests/test-subrepo-missing.t

py3: suppress the return value of open() in tests/test-subrepo-missing.t
ClosedPublic

Revision Contents
Changeset List