This is an archive of the discontinued Mercurial Phabricator instance.

py3: suppress the return value of open() in tests/test-subrepo-missing.t
ClosedPublic

Authored by pulkit on Apr 12 2018, 8:07 AM.

Details

Summary

open() on Python 3 returns a value whereas does not return anything on Python 2.
So we need to supress the value.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Apr 12 2018, 8:07 AM
indygreg accepted this revision.Apr 12 2018, 11:06 AM
indygreg added a subscriber: indygreg.

Nit: (I've seen a few commit messages with this mistake.) The thing whose return is being suppressed is .write() not open().

This revision is now accepted and ready to land.Apr 12 2018, 11:06 AM
This revision was automatically updated to reflect the committed changes.

Nit: (I've seen a few commit messages with this mistake.) The thing whose return is being suppressed is .write() not open().

If you can fix the commit message on flight, please do. I will take care of this next time.