This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3307

context: set stack level for deprecation warning
ClosedPublic

Authored by martinvonz on Apr 13 2018, 1:07 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG1764527af92e: context: set stack level for deprecation warning
Summary

This patch makes the deprecation warning print the caller of
repo.getitem. That's not quite correct, since there could also be
other callers of changectx.init, but it seems like the most
helpful stack level in practice.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Revision Contents
Changeset List

PathPackages
Mmercurial/context.py (2 lines)

Diff 8258

mercurial/context.py

# * If you know that "x" is a hex nodeid prefix, use # * If you know that "x" is a hex nodeid prefix, use
# repo[scmutil.resolvepartialhexnodeid(repo, x)] # repo[scmutil.resolvepartialhexnodeid(repo, x)]
# * If "x" is a string that can be any of the above, but you don't want # * If "x" is a string that can be any of the above, but you don't want
# to allow general revsets (perhaps because "x" may come from a remote # to allow general revsets (perhaps because "x" may come from a remote
# user and the revset may be too costly), use scmutil.revsymbol(repo, x) # user and the revset may be too costly), use scmutil.revsymbol(repo, x)
# * If "x" can be a mix of the above, you'll have to figure it out # * If "x" can be a mix of the above, you'll have to figure it out
# yourself # yourself
repo.ui.deprecwarn("changectx.__init__ is getting more limited, see source " repo.ui.deprecwarn("changectx.__init__ is getting more limited, see source "
"for details", "4.6") "for details", "4.6", stacklevel=4)
class changectx(basectx): class changectx(basectx):
"""A changecontext object makes access to data related to a particular """A changecontext object makes access to data related to a particular
changeset convenient. It represents a read-only context already present in changeset convenient. It represents a read-only context already present in
the repo.""" the repo."""
def __init__(self, repo, changeid='.'): def __init__(self, repo, changeid='.'):
"""changeid is a revision number, node, or tag""" """changeid is a revision number, node, or tag"""
super(changectx, self).__init__(repo) super(changectx, self).__init__(repo)