This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3463

directaccess: use resolvehexnodeidprefix() instead of _partialmatch()
ClosedPublic

Authored by martinvonz on May 7 2018, 6:19 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG69de3c3de036: directaccess: use resolvehexnodeidprefix() instead of _partialmatch()
Summary

Same reasoning as previous commit: I want to make
resolvehexnodeidprefix() move complex and don't want to duplicate that
code in directaccess.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 7 2018, 6:19 PM
Closed by commit rHG69de3c3de036: directaccess: use resolvehexnodeidprefix() instead of _partialmatch() (authored by martinvonz). · Explain WhyMay 8 2018, 8:47 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (3 lines)

Diff 8518

mercurial/scmutil.py

def _getrevsfromsymbols(repo, symbols): def _getrevsfromsymbols(repo, symbols):
"""parse the list of symbols and returns a set of revision numbers of hidden """parse the list of symbols and returns a set of revision numbers of hidden
changesets present in symbols""" changesets present in symbols"""
revs = set() revs = set()
unfi = repo.unfiltered() unfi = repo.unfiltered()
unficl = unfi.changelog unficl = unfi.changelog
cl = repo.changelog cl = repo.changelog
tiprev = len(unficl) tiprev = len(unficl)
pmatch = unficl._partialmatch
allowrevnums = repo.ui.configbool('experimental', 'directaccess.revnums') allowrevnums = repo.ui.configbool('experimental', 'directaccess.revnums')
for s in symbols: for s in symbols:
try: try:
n = int(s) n = int(s)
if n <= tiprev: if n <= tiprev:
if not allowrevnums: if not allowrevnums:
continue continue
else: else:
if n not in cl: if n not in cl:
revs.add(n) revs.add(n)
continue continue
except ValueError: except ValueError:
pass pass
try: try:
s = pmatch(s) s = resolvehexnodeidprefix(unfi, s)
except (error.LookupError, error.WdirUnsupported): except (error.LookupError, error.WdirUnsupported):
s = None s = None
if s is not None: if s is not None:
rev = unficl.rev(s) rev = unficl.rev(s)
if rev not in cl: if rev not in cl:
revs.add(rev) revs.add(rev)
return revs return revs