This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3337

localrepo: add some overlooked strkwargs love for py3
ClosedPublic

Authored by durin42 on Apr 13 2018, 6:33 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG719b8cb22936: localrepo: add some overlooked strkwargs love for py3
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 13 2018, 6:33 PM
indygreg accepted this revision.Apr 13 2018, 7:16 PM
indygreg added a subscriber: indygreg.

Doh. I got it right everywhere but one place :)

This revision is now accepted and ready to land.Apr 13 2018, 7:16 PM
Closed by commit rHG719b8cb22936: localrepo: add some overlooked strkwargs love for py3 (authored by durin42). · Explain WhyApr 13 2018, 7:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/localrepo.py (2 lines)

Diff 8209

mercurial/localrepo.py

# We don't need to support anything fancy. Just call the named # We don't need to support anything fancy. Just call the named
# method on the peer and return a resolved future. # method on the peer and return a resolved future.
fn = getattr(self._peer, pycompat.sysstr(command)) fn = getattr(self._peer, pycompat.sysstr(command))
f = pycompat.futures.Future() f = pycompat.futures.Future()
try: try:
result = fn(**args) result = fn(**pycompat.strkwargs(args))
except Exception: except Exception:
pycompat.future_set_exception_info(f, sys.exc_info()[1:]) pycompat.future_set_exception_info(f, sys.exc_info()[1:])
else: else:
f.set_result(result) f.set_result(result)
return f return f
def sendcommands(self): def sendcommands(self):