This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3363

tests: port inline extensions in test-hook.t to py3
ClosedPublic

Authored by durin42 on Apr 14 2018, 12:32 AM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG9bbb13c0f982: tests: port inline extensions in test-hook.t to py3
Summary

This test *almost* passes now, but some import errors print very
differently in ways that seem at least somewhat important.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Apr 14 2018, 12:32 AM
indygreg accepted this revision.Apr 16 2018, 7:18 PM
This revision is now accepted and ready to land.Apr 16 2018, 7:18 PM
Closed by commit rHG9bbb13c0f982: tests: port inline extensions in test-hook.t to py3 (authored by durin42). · Explain WhyApr 16 2018, 7:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-hook.t (18 lines)

Diff 8357

tests/test-hook.t

commit hooks can see env vars commit hooks can see env vars
(and post-transaction one are run unlocked) (and post-transaction one are run unlocked)
$ cat > $TESTTMP/txnabort.checkargs.py <<EOF $ cat > $TESTTMP/txnabort.checkargs.py <<EOF
> from mercurial import pycompat
> def showargs(ui, repo, hooktype, **kwargs): > def showargs(ui, repo, hooktype, **kwargs):
> ui.write('%s Python hook: %s\n' % (hooktype, ','.join(sorted(kwargs)))) > kwargs = pycompat.byteskwargs(kwargs)
> ui.write(b'%s Python hook: %s\n' % (hooktype,
> b','.join(sorted(kwargs))))
> EOF > EOF
$ hg init a $ hg init a
$ cd a $ cd a
$ cat > .hg/hgrc <<EOF $ cat > .hg/hgrc <<EOF
> [hooks] > [hooks]
> commit = sh -c "HG_LOCAL= HG_TAG= printenv.py commit" > commit = sh -c "HG_LOCAL= HG_TAG= printenv.py commit"
> commit.b = sh -c "HG_LOCAL= HG_TAG= printenv.py commit.b" > commit.b = sh -c "HG_LOCAL= HG_TAG= printenv.py commit.b"
preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid HG_HOOKTYPE=preoutgoing HG_SOURCE=clone preoutgoing.forbid hook: HG_HOOKNAME=preoutgoing.forbid HG_HOOKTYPE=preoutgoing HG_SOURCE=clone
abort: preoutgoing.forbid hook exited with status 1 abort: preoutgoing.forbid hook exited with status 1
[255] [255]
$ cd "$TESTTMP/b" $ cd "$TESTTMP/b"
$ cat > hooktests.py <<EOF $ cat > hooktests.py <<EOF
> from __future__ import print_function > from __future__ import print_function
> from mercurial import error > from mercurial import (
> error,
> pycompat,
> )
> >
> uncallable = 0 > uncallable = 0
> >
> def printargs(ui, args): > def printargs(ui, args):
> a = list(args.items()) > a = list(pycompat.byteskwargs(args).items())
> a.sort() > a.sort()
> ui.write(b'hook args:\n') > ui.write(b'hook args:\n')
> for k, v in a: > for k, v in a:
> ui.write(b' %s %s\n' % (k, v)) > ui.write(b' %s %s\n' % (k, v))
> >
> def passhook(ui, repo, **args): > def passhook(ui, repo, **args):
> printargs(ui, args) > printargs(ui, args)
> >
> def failhook(ui, repo, **args): > def failhook(ui, repo, **args):
> printargs(ui, args) > printargs(ui, args)
> return True > return True
> >
> class LocalException(Exception): > class LocalException(Exception):
> pass > pass
> >
> def raisehook(**args): > def raisehook(**args):
> raise LocalException(b'exception from hook') > raise LocalException('exception from hook')
> >
> def aborthook(**args): > def aborthook(**args):
> raise error.Abort(b'raise abort from hook') > raise error.Abort(b'raise abort from hook')
> >
> def brokenhook(**args): > def brokenhook(**args):
> return 1 + {} > return 1 + {}
> >
> def verbosehook(ui, **args): > def verbosehook(ui, **args):
Traceback (most recent call last): Traceback (most recent call last):
$ cd .. $ cd ..
$ hg init c $ hg init c
$ cd c $ cd c
$ cat > hookext.py <<EOF $ cat > hookext.py <<EOF
> def autohook(ui, **args): > def autohook(ui, **args):
> ui.write('Automatically installed hook\n') > ui.write(b'Automatically installed hook\n')
> >
> def reposetup(ui, repo): > def reposetup(ui, repo):
> repo.ui.setconfig("hooks", "commit.auto", autohook) > repo.ui.setconfig(b"hooks", b"commit.auto", autohook)
> EOF > EOF
$ echo '[extensions]' >> .hg/hgrc $ echo '[extensions]' >> .hg/hgrc
$ echo 'hookext = hookext.py' >> .hg/hgrc $ echo 'hookext = hookext.py' >> .hg/hgrc
$ touch foo $ touch foo
$ hg add foo $ hg add foo
$ hg ci -d '0 0' -m 'add foo' $ hg ci -d '0 0' -m 'add foo'
Automatically installed hook Automatically installed hook