This is an archive of the discontinued Mercurial Phabricator instance.

wireprotov2: establish a type for representing command response
ClosedPublic

Authored by indygreg on Apr 14 2018, 8:21 PM.

Details

Summary

It will be desirable to have a higher-level type for representing
command responses. This will allow us to do nicer things.

For now, the instance encapsulates existing logic. It is still
a bit primitive. But we're slowly making things better.

Version 1 protocols have a wrapping layer that decodes the raw
string data into a data structure and that data structure is
sent to the future. Version 2 doesn't yet have this layer and
the future is receiving the raw wire response. Hence why
debugcommands needed to be taught about the response type.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 14 2018, 8:21 PM
durin42 accepted this revision.Apr 16 2018, 6:52 PM
This revision is now accepted and ready to land.Apr 16 2018, 6:52 PM
This revision was automatically updated to reflect the committed changes.