This is an archive of the discontinued Mercurial Phabricator instance.

wireprotov2: change behavior of error frame
ClosedPublic

Authored by indygreg on Apr 14 2018, 8:21 PM.

Details

Summary

Now that we have a leading CBOR map in command response frames
to indicate overall command result status, we don't need to use
the error response frame to represent command errors. Instead,
we can reserve it for protocol and server level errors. And for the
special case of a command error that occurred after command response
frames were emitted.

The code for error handling still needs a ton of work. But we're
slowly going in the right direction...

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 14 2018, 8:21 PM
durin42 accepted this revision.Apr 16 2018, 6:52 PM
This revision is now accepted and ready to land.Apr 16 2018, 6:52 PM
This revision was automatically updated to reflect the committed changes.