This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3391

commands: use command executor interface
ClosedPublic

Authored by indygreg on Apr 16 2018, 7:04 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG9b3a348c9b2f: commands: use command executor interface
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 16 2018, 7:04 PM
durin42 accepted this revision.Apr 16 2018, 10:42 PM
This revision is now accepted and ready to land.Apr 16 2018, 10:42 PM
Closed by commit rHG9b3a348c9b2f: commands: use command executor interface (authored by indygreg). · Explain WhyApr 16 2018, 10:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (4 lines)

Diff 8318

mercurial/commands.py

if revs: if revs:
try: try:
# When 'rev' is a bookmark name, we cannot guarantee that it # When 'rev' is a bookmark name, we cannot guarantee that it
# will be updated with that name because of a race condition # will be updated with that name because of a race condition
# server side. (See issue 4689 for details) # server side. (See issue 4689 for details)
oldrevs = revs oldrevs = revs
revs = [] # actually, nodes revs = [] # actually, nodes
for r in oldrevs: for r in oldrevs:
node = other.lookup(r) with other.commandexecutor() as e:
node = e.callcommand('lookup', {'key': r}).result()
revs.append(node) revs.append(node)
if r == checkout: if r == checkout:
checkout = node checkout = node
except error.CapabilityError: except error.CapabilityError:
err = _("other repository doesn't support revision lookup, " err = _("other repository doesn't support revision lookup, "
"so a rev cannot be specified.") "so a rev cannot be specified.")
raise error.Abort(err) raise error.Abort(err)