This is an archive of the discontinued Mercurial Phabricator instance.

wireproto: make version 2 @wireprotocommand an independent function
ClosedPublic

Authored by indygreg on Apr 17 2018, 1:30 AM.

Details

Summary

Previously, the code for this decorator was shared between version 1
and version 2 commands. Very few parts of the function were identical.
So I don't think sharing is justified.

wireprotov2server now has its own @wireprotocommand decorator function.
Because the decorator is no longer shared, code for configuring the
transport policy has been removed. i.e. commands must have separate
implementations for each wire protocol version.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Apr 17 2018, 1:30 AM
durin42 accepted this revision.Apr 18 2018, 2:25 PM
This revision is now accepted and ready to land.Apr 18 2018, 2:25 PM
This revision was automatically updated to reflect the committed changes.