This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3432

hgweb: guard against empty Content-Length header
ClosedPublic

Authored by indygreg on Apr 27 2018, 5:52 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHGe82b137a8b4e: hgweb: guard against empty Content-Length header
Summary

Discussion in issue 5860 seems to indicate this can occur.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Apr 27 2018, 5:52 PM
durin42 accepted this revision.Apr 30 2018, 10:31 AM
This revision is now accepted and ready to land.Apr 30 2018, 10:31 AM
Closed by commit rHGe82b137a8b4e: hgweb: guard against empty Content-Length header (authored by indygreg). · Explain WhyApr 30 2018, 10:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/hgweb/request.py (3 lines)

Diff 8440

mercurial/hgweb/request.py

headers['Content-Length'] = env['CONTENT_LENGTH'] headers['Content-Length'] = env['CONTENT_LENGTH']
if 'CONTENT_TYPE' in env and 'HTTP_CONTENT_TYPE' not in env: if 'CONTENT_TYPE' in env and 'HTTP_CONTENT_TYPE' not in env:
headers['Content-Type'] = env['CONTENT_TYPE'] headers['Content-Type'] = env['CONTENT_TYPE']
if bodyfh is None: if bodyfh is None:
bodyfh = env['wsgi.input'] bodyfh = env['wsgi.input']
if 'Content-Length' in headers: if 'Content-Length' in headers:
bodyfh = util.cappedreader(bodyfh, int(headers['Content-Length'])) bodyfh = util.cappedreader(bodyfh,
int(headers['Content-Length'] or '0'))
return parsedrequest(method=env['REQUEST_METHOD'], return parsedrequest(method=env['REQUEST_METHOD'],
url=fullurl, baseurl=baseurl, url=fullurl, baseurl=baseurl,
advertisedurl=advertisedfullurl, advertisedurl=advertisedfullurl,
advertisedbaseurl=advertisedbaseurl, advertisedbaseurl=advertisedbaseurl,
urlscheme=env['wsgi.url_scheme'], urlscheme=env['wsgi.url_scheme'],
remoteuser=env.get('REMOTE_USER'), remoteuser=env.get('REMOTE_USER'),
remotehost=env.get('REMOTE_HOST'), remotehost=env.get('REMOTE_HOST'),