This is an archive of the discontinued Mercurial Phabricator instance.

Differential D345

rebase: optimize "source" calculation in adjustdest
ClosedPublic

Authored by quark on Aug 11 2017, 5:01 AM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHG3ae2eaecb49e: rebase: optimize "source" calculation in adjustdest
Summary

The "source" variable is calculated inside a loop but it does not depend on
loop variables. Therefore move it outside the loop.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

quark created this revision.Aug 11 2017, 5:01 AM
martinvonz accepted this revision.Aug 16 2017, 1:57 AM
This revision is now accepted and ready to land.Aug 16 2017, 1:57 AM
Closed by commit rHG3ae2eaecb49e: rebase: optimize "source" calculation in adjustdest (authored by quark). · Explain WhyAug 16 2017, 2:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/rebase.py (5 lines)

Diff 982

hgext/rebase.py

F G |/ F G |/
K | | -> K K | | -> K
| C D | | C D |
| |/ | | |/ |
| B | ... | B | ...
|/ |/ |/ |/
A A A A
""" """
# pick already rebased revs from state
source = [s for s, d in state.items() if d > 0]
result = [] result = []
for prev in repo.changelog.parentrevs(rev): for prev in repo.changelog.parentrevs(rev):
adjusted = dest adjusted = dest
if prev != nullrev: if prev != nullrev:
# pick already rebased revs from state
source = [s for s, d in state.items() if d > 0]
candidate = repo.revs('max(%ld and (::%d))', source, prev).first() candidate = repo.revs('max(%ld and (::%d))', source, prev).first()
if candidate is not None: if candidate is not None:
adjusted = state[candidate] adjusted = state[candidate]
result.append(adjusted) result.append(adjusted)
return result return result
def _checkobsrebase(repo, ui, rebaseobsrevs, rebaseobsskipped): def _checkobsrebase(repo, ui, rebaseobsrevs, rebaseobsskipped):
""" """