( )⚙ D3501 shortest: remove unnecessary check for revnum in isvalid()

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3501

shortest: remove unnecessary check for revnum in isvalid()
ClosedPublic

Authored by martinvonz on May 8 2018, 2:07 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG76e933e0ccc9: shortest: remove unnecessary check for revnum in isvalid()
Summary

We now always disambiguating against revnums after we've found an
otherwise valid prefix, so we can safely remove the early isrev()
check in isvalid().

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.May 8 2018, 2:07 PM
Closed by commit rHG76e933e0ccc9: shortest: remove unnecessary check for revnum in isvalid() (authored by martinvonz). · Explain WhyMay 11 2018, 3:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8641

mercurial/revlog.py

node = self._partialmatch(prefix) node = self._partialmatch(prefix)
except error.RevlogError: except error.RevlogError:
return False return False
except error.WdirUnsupported: except error.WdirUnsupported:
# single 'ff...' match # single 'ff...' match
return True return True
if node is None: if node is None:
raise LookupError(node, self.indexfile, _('no node')) raise LookupError(node, self.indexfile, _('no node'))
return not isrev(prefix) return True
def maybewdir(prefix): def maybewdir(prefix):
return all(c == 'f' for c in prefix) return all(c == 'f' for c in prefix)
hexnode = hex(node) hexnode = hex(node)
def disambiguate(hexnode, minlength): def disambiguate(hexnode, minlength):
for length in range(minlength, 41): for length in range(minlength, 41):