( )⚙ D3504 cborutil: port to Python 3

This is an archive of the discontinued Mercurial Phabricator instance.

cborutil: port to Python 3
ClosedPublic

Authored by durin42 on May 8 2018, 3:27 PM.

Details

Summary

The only problem lurking in here was sorts of mismatched types. The
sorts are only for output stability in our tests (sigh), so we just
build a phony sort key using the name of types so that we only
compare like types against each other. By pure luck, my awful sort key
matches the behavior we get "for free" in Python 2, so no test output
changes.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 8 2018, 3:27 PM
indygreg accepted this revision.May 8 2018, 4:18 PM
indygreg added a subscriber: indygreg.

Ugh.

This revision is now accepted and ready to land.May 8 2018, 4:18 PM
This revision was automatically updated to reflect the committed changes.