This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3512

tests: port test-ui-color.py to Python 3
ClosedPublic

Authored by durin42 on May 8 2018, 4:46 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGb8c2004a8d2b: tests: port test-ui-color.py to Python 3
Summary

As in some other tests, I like confirming that we're dealing with
bytes here, so the b prefix is now in the expected output on both 2
and 3.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.May 8 2018, 4:46 PM
pulkit accepted this revision.May 9 2018, 6:47 PM
Closed by commit rHGb8c2004a8d2b: tests: port test-ui-color.py to Python 3 (authored by durin42). · Explain WhyMay 10 2018, 6:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 8605

contrib/python3-whitelist

test-subrepo-recursion.t test-subrepo-recursion.t
test-subrepo-relative-path.t test-subrepo-relative-path.t
test-subrepo.t test-subrepo.t
test-symlinks.t test-symlinks.t
test-tag.t test-tag.t
test-tags.t test-tags.t
test-template-engine.t test-template-engine.t
test-treemanifest.t test-treemanifest.t
test-ui-color.py
test-unamend.t test-unamend.t
test-uncommit.t test-uncommit.t
test-unified-test.t test-unified-test.t
test-unrelated-pull.t test-unrelated-pull.t
test-up-local-change.t test-up-local-change.t
test-update-branches.t test-update-branches.t
test-update-dest.t test-update-dest.t
test-update-issue1456.t test-update-issue1456.t

tests/test-ui-color.py

from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
import os import os
from mercurial import ( from mercurial import (
dispatch, dispatch,
ui as uimod, ui as uimod,
) )
from mercurial.utils import (
stringutil,
)
# ensure errors aren't buffered # ensure errors aren't buffered
testui = uimod.ui() testui = uimod.ui()
testui.pushbuffer() testui.pushbuffer()
testui.write((b'buffered\n')) testui.write((b'buffered\n'))
testui.warn((b'warning\n')) testui.warn((b'warning\n'))
testui.write_err(b'error\n') testui.write_err(b'error\n')
print(repr(testui.popbuffer())) print(stringutil.pprint(testui.popbuffer()).decode('ascii'))
# test dispatch.dispatch with the same ui object # test dispatch.dispatch with the same ui object
hgrc = open(os.environ["HGRCPATH"], 'wb') hgrc = open(os.environ["HGRCPATH"], 'wb')
hgrc.write(b'[extensions]\n') hgrc.write(b'[extensions]\n')
hgrc.write(b'color=\n') hgrc.write(b'color=\n')
hgrc.close() hgrc.close()
ui_ = uimod.ui.load() ui_ = uimod.ui.load()
ui_.setconfig(b'ui', b'formatted', b'True') ui_.setconfig(b'ui', b'formatted', b'True')
# we're not interested in the output, so write that to devnull # we're not interested in the output, so write that to devnull
ui_.fout = open(os.devnull, 'wb') ui_.fout = open(os.devnull, 'wb')
# call some arbitrary command just so we go through # call some arbitrary command just so we go through
# color's wrapped _runcommand twice. # color's wrapped _runcommand twice.
def runcmd(): def runcmd():
dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_)) dispatch.dispatch(dispatch.request([b'version', b'-q'], ui_))
runcmd() runcmd()
print("colored? %s" % (ui_._colormode is not None)) print("colored? %s" % (ui_._colormode is not None))
runcmd() runcmd()
print("colored? %s" % (ui_._colormode is not None)) print("colored? %s" % (ui_._colormode is not None))

tests/test-ui-color.py.out

warning warning
error error
'buffered\n' b'buffered\n'
colored? True colored? True
colored? True colored? True