Page MenuHomePhabricator

chgserver: special handle __version__ in mtimehash (issue5653)

Authored by quark on Aug 11 2017, 2:27 PM.


Group Reviewers

It seems may have content change without mtime change. Since
reading is usually cheap, check its content instead of
stating it. This should make chg able to detect version change when the
package manager upgrades files with mtime preserved and size happens to be

Diff Detail

rHG Mercurial
Lint Skipped
Unit Tests Skipped

Event Timeline

quark created this revision.Aug 11 2017, 2:27 PM
yuja added a subscriber: yuja.Aug 15 2017, 3:09 AM

I doubt the issue5653 had this scenario. Waiting for more detailed bug report.

quark added a comment.Aug 15 2017, 7:30 PM

I will test it on a Mac tomorrow. I think this patch is optional (nice to have).

FB also has some weird reports that suggest demandimport is causing chg to load a mix of old and new modules. So the first two patches are more important in terms of correctness.

yuja added a comment.Aug 17 2017, 8:44 AM

I'll drop this per your comment on the issue5653. Thanks for investigating it further.

quark abandoned this revision.Aug 17 2017, 11:13 AM