py3: convert the report to bytes
ClosedPublic

Authored by pulkit on May 15 2018, 10:48 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG5046c906b25d: py3: convert the report to bytes
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
pulkit created this revision.May 15 2018, 10:48 PM
yuja added a subscriber: yuja.May 16 2018, 7:42 AM
    • a/mercurial/dispatch.py +++ b/mercurial/dispatch.py @@ -1028,7 +1028,7 @@ ' which supports versions %s of Mercurial.\n' ' Please disable %s and try your action again.\n' '** If that fixes the bug please report it to %s\n')
  • % (name, testedwith, name, report)) + % (name, testedwith, name, pycompat.bytestr(report)))

Maybe stringutil.forcebytestr()?

The report must be bytes, but a broken extension might provide a unicode
for example, and a unicode can't always be byte-ified with bytestr().

pulkit updated this revision to Diff 8719.May 16 2018, 3:30 PM
This revision was automatically updated to reflect the committed changes.