This is an archive of the discontinued Mercurial Phabricator instance.

bundle = None
try:  # guards bundle
bundlepath = "bundle:%s+%s" % (op.repo.root, bundlefile)

+ bundlepath = "bundle:%s+%s" % (op.repo.root,
+ pycompat.fsencode(bundlefile))

It's probably better to handle this by callers because a filename passed
to a Mercurial function should always be bytes.

Revision Contents
Changeset List

			Path	Packages
M			hgext/infinitepush/__init__.py (3 lines)

Commit	Parents	Author	Summary	Date
		Pulkit Goyal		May 19 2018, 9:26 AM

Status	Author	Revision
Closed	pulkit	D3615 py3: add 13 new passing tests to whitelist
Closed	pulkit	D3614 py3: check for None before comparing with integers
Closed	pulkit	D3613 py3: use `except error as e` instead of `except error, e`
Closed	pulkit	D3612 py3: use pycompat.fsencode() to convert tempfile name to bytes
Closed	pulkit	D3611 py3: add b'' prefixes in tests/test-parseindex.t
Closed	pulkit	D3610 py3: fix .write() calls in few tests
Closed	pulkit	D3609 py3: bytestr() bytes to get bytechar while iterating on it
Closed	pulkit	D3608 py3: slice over bytes to prevent getting the ascii values
Closed	pulkit	D3607 py3: use utils.stringutil.forcebytestr to convert error to bytes
Closed	pulkit	D3606 py3: make sure we open files in bytes mode
Closed	pulkit	D3605 py3: add b'' prefix in test/test-fileset.t
Closed	pulkit	D3604 py3: suppress the output from .write() calls in few tests
Closed	pulkit	D3603 py3: use print as a function in tests/test-parseindex.t
Closed	pulkit	D3602 py3: use print as a function in tests/test-pull.t
Closed	pulkit	D3601 py3: add b'' prefixes in tests/test-rebuildstate.t
Closed	pulkit	D3600 py3: add b'' prefixes in tests/test-progress.t
Closed	pulkit	D3599 py3: add b'' prefixes in tests/test-profile.t
Closed	pulkit	D3598 py3: add b'' prefixes in tests/test-pager.t
Closed	pulkit	D3597 py3: add b'' prefixes in tests/test-hgrc.t
Closed	pulkit	D3596 py3: add b'' prefixes in tests/test-extensions-afterloaded.t
Closed	pulkit	D3595 py3: add b'' prefixes in tests/test-custom-filters.t
Closed	pulkit	D3594 py3: add b'' prefixes in tests/test-bugzilla.t
Closed	pulkit	D3593 py3: fix kwargs handling in hgext/split.py
Closed	pulkit	D3592 py3: add b'' prefixes in hgext/convert/subversion.py
Closed	pulkit	D3591 py3: use '%d' for integers in hgext/infinitepush/__init__.py
Closed	pulkit	D3590 py3: make sure we pass str to date.strftime()

Diff 8783

hgext/infinitepush/init.py

	parthandlerstart = time.time()			parthandlerstart = time.time()
	log(scratchbranchparttype, eventtype='start')			log(scratchbranchparttype, eventtype='start')
	index = op.repo.bundlestore.index			index = op.repo.bundlestore.index
	store = op.repo.bundlestore.store			store = op.repo.bundlestore.store
	op.records.add(scratchbranchparttype + '_skippushkey', True)			op.records.add(scratchbranchparttype + '_skippushkey', True)

	bundle = None			bundle = None
	try: # guards bundle			try: # guards bundle
	bundlepath = "bundle:%s+%s" % (op.repo.root, bundlefile)			bundlepath = "bundle:%s+%s" % (op.repo.root,
				pycompat.fsencode(bundlefile))
	bundle = hg.repository(op.repo.ui, bundlepath)			bundle = hg.repository(op.repo.ui, bundlepath)

	bookmark = params.get('bookmark')			bookmark = params.get('bookmark')
	bookprevnode = params.get('bookprevnode', '')			bookprevnode = params.get('bookprevnode', '')
	force = params.get('force')			force = params.get('force')

	if bookmark:			if bookmark:
	oldnode = index.getnode(bookmark)			oldnode = index.getnode(bookmark)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	8783		May 19 2018, 10:41 AM	★	★
Diff 2	8817	rHGca1cf9b3cce7e96c268e60ad30af9f8b8f43fc95	May 19 2018, 9:26 AM	★	★

This is an archive of the discontinued Mercurial Phabricator instance.

py3: use pycompat.fsencode() to convert tempfile name to bytesClosedPublic

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8783

hgext/infinitepush/__init__.py

py3: use pycompat.fsencode() to convert tempfile name to bytes
ClosedPublic

Revision Contents
Changeset List

hgext/infinitepush/init.py