This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3641

state: temporary silence pyflakes warning by removing variable assignment
ClosedPublic

Authored by pulkit on May 21 2018, 2:56 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGb7e5c53a779e: state: temporary silence pyflakes warning by removing variable assignment
Summary

The variable 'version' is going to be used in upcoming series where we will be
using the version number to read a certain state file. However currently,
pyflakes fails because of the variable not being used. Let's remove the
assignment temporarily so that buildbots and test-suite is happy until I iterate
over remaining part of the series.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.May 21 2018, 2:56 PM
Closed by commit rHGb7e5c53a779e: state: temporary silence pyflakes warning by removing variable assignment (authored by pulkit). · Explain WhyMay 22 2018, 8:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/state.py (2 lines)

Diff 8870

mercurial/state.py

fp.write('%d\n' % version) fp.write('%d\n' % version)
cbor.dump(self.opts, fp, canonical=True) cbor.dump(self.opts, fp, canonical=True)
def _read(self): def _read(self):
"""reads the state file and returns a dictionary which contain """reads the state file and returns a dictionary which contain
data in the same format as it was before storing""" data in the same format as it was before storing"""
with self._repo.vfs(self.fname, 'rb') as fp: with self._repo.vfs(self.fname, 'rb') as fp:
try: try:
version = int(fp.readline()) int(fp.readline())
except ValueError: except ValueError:
raise error.ProgrammingError("unknown version of state file" raise error.ProgrammingError("unknown version of state file"
" found") " found")
return cbor.load(fp) return cbor.load(fp)
def delete(self): def delete(self):
"""drop the state file if exists""" """drop the state file if exists"""
util.unlinkpath(self._repo.vfs.join(self.fname), ignoremissing=True) util.unlinkpath(self._repo.vfs.join(self.fname), ignoremissing=True)
def exists(self): def exists(self):
"""check whether the state file exists or not""" """check whether the state file exists or not"""
return self._repo.vfs.exists(self.fname) return self._repo.vfs.exists(self.fname)