Page MenuHomePhabricator

graft: reuse the --edit value passed initially in `hg graft --continue` (BC)
Needs RevisionPublic

Authored by pulkit on May 25 2018, 6:25 PM.

Details

Reviewers
baymax
Group Reviewers
hg-reviewers
Summary

This patch starts storing the value of --edit flag passed by the user initially
when they runs hg graft --edit. We can now read the value from graftstate in
case of --continue and respect the value which user passed earlier.

The tests changes demonstrate the fix.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

pulkit created this revision.May 25 2018, 6:25 PM
yuja added a subscriber: yuja.Jun 5 2018, 8:00 AM

Queued the first two, thanks.

This patch starts storing the value of --edit flag passed by the user initially
when they runs `hg graft --edit`. We can now read the value from graftstate in
case of `--continue` and respect the value which user passed earlier.

I'm -0.5 on this since --edit is an option to change the interactive behavior,
and I think we don't preserve such options across interrupted sessions.

baymax requested changes to this revision.Jan 24 2020, 12:33 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jan 24 2020, 12:33 PM