( )⚙ D3703 serve: do not daemonize by default by --print-url

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3703

serve: do not daemonize by default by --print-url
ClosedPublic

Authored by yuja on Jun 8 2018, 10:49 AM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG1a05e205832a: serve: do not daemonize by default by --print-url
Summary

Per discussion in D3649, -d/--daemon should be explicitly specified to avoid
surprising result.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

yuja created this revision.Jun 8 2018, 10:49 AM
durin42 accepted this revision.Jun 12 2018, 12:57 PM
This revision is now accepted and ready to land.Jun 12 2018, 12:57 PM
Closed by commit rHG1a05e205832a: serve: do not daemonize by default by --print-url (authored by yuja). · Explain WhyJun 12 2018, 1:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (2 lines)

Diff 8999

mercurial/commands.py

Returns 0 on success. Returns 0 on success.
""" """
opts = pycompat.byteskwargs(opts) opts = pycompat.byteskwargs(opts)
if opts["stdio"] and opts["cmdserver"]: if opts["stdio"] and opts["cmdserver"]:
raise error.Abort(_("cannot use --stdio with --cmdserver")) raise error.Abort(_("cannot use --stdio with --cmdserver"))
if opts["print_url"] and ui.verbose: if opts["print_url"] and ui.verbose:
raise error.Abort(_("cannot use --print-url with --verbose")) raise error.Abort(_("cannot use --print-url with --verbose"))
if opts["print_url"]:
opts['daemon'] = True
if opts["stdio"]: if opts["stdio"]:
if repo is None: if repo is None:
raise error.RepoError(_("there is no Mercurial repository here" raise error.RepoError(_("there is no Mercurial repository here"
" (.hg not found)")) " (.hg not found)"))
s = wireprotoserver.sshserver(ui, repo) s = wireprotoserver.sshserver(ui, repo)
s.serve_forever() s.serve_forever()