( )⚙ D3761 packaging: dynamically define make targets

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3761

packaging: dynamically define make targets
ClosedPublic

Authored by indygreg on Jun 16 2018, 2:19 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG7f738edc4a27: packaging: dynamically define make targets
Summary

We currently have make boilerplate for each instance of a distro's
release. This is redundant, annoying to maintain, and prone to errors.

This commit defines variables holding available releases for
various distros. We then iterate through the list and dynamically
define make targets.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

indygreg created this revision.Jun 16 2018, 2:19 PM
durin42 accepted this revision.Jun 25 2018, 10:50 AM
This revision is now accepted and ready to land.Jun 25 2018, 10:50 AM
Closed by commit rHG7f738edc4a27: packaging: dynamically define make targets (authored by indygreg). · Explain WhyJun 25 2018, 11:20 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/packaging/Makefile (166 lines)

Diff 9113

contrib/packaging/Makefile

$(eval HGROOT := $(shell cd ../..; pwd)) $(eval HGROOT := $(shell cd ../..; pwd))
DEBIAN_CODENAMES := \
jessie \
stretch \
buster
UBUNTU_CODENAMES := \
trusty \
xenial \
artful \
bionic \
FEDORA_RELEASES := \
20 \
21
CENTOS_RELEASES := \
5 \
6 \
7
# Build a Python for these CentOS releases.
CENTOS_WITH_PYTHON_RELEASES := 5 6
help: help:
@echo 'Packaging Make Targets' @echo 'Packaging Make Targets'
@echo '' @echo ''
@echo 'docker-centos-{5, 6, 7}' @echo 'docker-centos-{$(strip $(CENTOS_RELEASES))}'
@echo ' Build an RPM for a specific CentOS version using Docker.' @echo ' Build an RPM for a specific CentOS version using Docker.'
@echo '' @echo ''
@echo 'docker-debian-{jessie, stretch}' @echo 'docker-debian-{$(strip $(DEBIAN_CODENAMES))}'
@echo ' Build Debian packages specific to a Debian distro using Docker.' @echo ' Build Debian packages specific to a Debian distro using Docker.'
@echo '' @echo ''
@echo 'docker-fedora-{20, 21}' @echo 'docker-fedora-{$(strip $(FEDORA_RELEASES))}'
@echo ' Build an RPM for a specific Fedora version using Docker.' @echo ' Build an RPM for a specific Fedora version using Docker.'
@echo '' @echo ''
@echo 'docker-ubuntu-{trusty, xenial, artful, bionic}' @echo 'docker-ubuntu-{$(strip $(UBUNTU_CODENAMES))}'
@echo ' Build Debian package specific to an Ubuntu distro using Docker.' @echo ' Build Debian package specific to an Ubuntu distro using Docker.'
@echo '' @echo ''
@echo 'docker-ubuntu-{trusty, xenial, artful, bionic}-ppa' @echo 'docker-ubuntu-{$(strip $(UBUNTU_CODENAMES))}-ppa'
@echo ' Build a source-only Debian package specific to an Ubuntu distro' @echo ' Build a source-only Debian package specific to an Ubuntu distro'
@echo ' using Docker.' @echo ' using Docker.'
@echo '' @echo ''
@echo 'linux-wheels' @echo 'linux-wheels'
@echo ' Build Linux manylinux wheels using Docker.' @echo ' Build Linux manylinux wheels using Docker.'
@echo '' @echo ''
@echo 'linux-wheels-{x86_64, i686}' @echo 'linux-wheels-{x86_64, i686}'
@echo ' Build Linux manylinux wheels for a specific architecture using Docker' @echo ' Build Linux manylinux wheels for a specific architecture using Docker'
@echo '' @echo ''
@echo 'deb' @echo 'deb'
@echo ' Build a Debian package locally targeting the current system' @echo ' Build a Debian package locally targeting the current system'
@echo '' @echo ''
@echo 'ppa' @echo 'ppa'
@echo ' Build a Debian source package locally targeting the current system' @echo ' Build a Debian source package locally targeting the current system'
@echo '' @echo ''
@echo 'centos-{5, 6, 7}' @echo 'centos-{$(strip $(CENTOS_RELEASES))}'
@echo ' Build an RPM for a specific CentOS version locally' @echo ' Build an RPM for a specific CentOS version locally'
@echo '' @echo ''
@echo 'fedora-{20, 21}' @echo 'fedora-{$(strip $(FEDORA_RELEASES))}'
@echo ' Build an RPM for a specific Fedora version locally' @echo ' Build an RPM for a specific Fedora version locally'
.PHONY: help .PHONY: help
.PHONY: deb .PHONY: deb
deb: deb:
./builddeb ./builddeb
.PHONY: ppa .PHONY: ppa
ppa: ppa:
./builddeb --source-only ./builddeb --source-only
.PHONY: docker-debian-jessie # Debian targets.
docker-debian-jessie: define debian_targets =
./dockerdeb debian jessie .PHONY: docker-debian-$(1)
docker-debian-$(1):
.PHONY: docker-debian-stretch ./dockerdeb debian $(1)
docker-debian-stretch:
./dockerdeb debian stretch endef
.PHONY: docker-ubuntu-trusty $(foreach codename,$(DEBIAN_CODENAMES),$(eval $(call debian_targets,$(codename))))
docker-ubuntu-trusty:
./dockerdeb ubuntu trusty # Ubuntu targets.
define ubuntu_targets =
.PHONY: docker-ubuntu-trusty-ppa .PHONY: docker-ubuntu-$(1)
docker-ubuntu-trusty-ppa: docker-ubuntu-$(1):
./dockerdeb ubuntu trusty --source-only ./dockerdeb ubuntu $(1)
.PHONY: docker-ubuntu-xenial .PHONY: docker-ubuntu-$(1)-ppa
docker-ubuntu-xenial: docker-ubuntu-$(1)-ppa:
./dockerdeb ubuntu xenial ./dockerdeb ubuntu $(1) --source-only
.PHONY: docker-ubuntu-xenial-ppa endef
docker-ubuntu-xenial-ppa:
./dockerdeb ubuntu xenial --source-only $(foreach codename,$(UBUNTU_CODENAMES),$(eval $(call ubuntu_targets,$(codename))))
.PHONY: docker-ubuntu-artful # Fedora targets.
docker-ubuntu-artful: define fedora_targets =
./dockerdeb ubuntu artful .PHONY: fedora$(1)
fedora$(1):
.PHONY: docker-ubuntu-artful-ppa mkdir -p $$(HGROOT)/packages/fedora$(1)
docker-ubuntu-artful-ppa:
./dockerdeb ubuntu artful --source-only
.PHONY: docker-ubuntu-bionic
docker-ubuntu-bionic:
./dockerdeb ubuntu bionic
.PHONY: docker-ubuntu-bionic-ppa
docker-ubuntu-bionic-ppa:
./dockerdeb ubuntu bionic --source-only
.PHONY: fedora20
fedora20:
mkdir -p $(HGROOT)/packages/fedora20
./buildrpm ./buildrpm
cp $(HGROOT)/rpmbuild/RPMS/*/* $(HGROOT)/packages/fedora20 cp $$(HGROOT)/rpmbuild/RPMS/*/* $$(HGROOT)/packages/fedora$(1)
cp $(HGROOT)/rpmbuild/SRPMS/* $(HGROOT)/packages/fedora20 cp $$(HGROOT)/rpmbuild/SRPMS/* $$(HGROOT)/packages/fedora$(1)
rm -rf $(HGROOT)/rpmbuild rm -rf $(HGROOT)/rpmbuild
.PHONY: docker-fedora20 .PHONY: docker-fedora$(1)
docker-fedora20: docker-fedora$(1):
mkdir -p $(HGROOT)/packages/fedora20 mkdir -p $$(HGROOT)/packages/fedora($1)
./dockerrpm fedora20 ./dockerrpm fedora$(1)
.PHONY: fedora21 endef
fedora21:
mkdir -p $(HGROOT)/packages/fedora21 $(foreach release,$(FEDORA_RELEASES),$(eval $(call fedora_targets,$(release))))
./buildrpm
cp $(HGROOT)/rpmbuild/RPMS/*/* $(HGROOT)/packages/fedora21 # CentOS targets.
cp $(HGROOT)/rpmbuild/SRPMS/* $(HGROOT)/packages/fedora21 define centos_targets
rm -rf $(HGROOT)/rpmbuild .PHONY: centos$(1)
centos$(1):
mkdir -p $$(HGROOT)/packages/centos$(1)
./buildrpm $$(if $$(filter $(1),$$(CENTOS_WITH_PYTHON_RELEASES)),--withpython)
cp $$(HGROOT)/rpmbuild/RPMS/*/* $$(HGROOT)/packages/centos$(1)
cp $$(HGROOT)/rpmbuild/SRPMS/* $$(HGROOT)/packages/centos$(1)
.PHONY: docker-centos$(1)
docker-centos$(1):
mkdir -p $$(HGROOT)/packages/centos$(1)
./dockerrpm centos$(1) $$(if $$(filter $(1),$$(CENTOS_WITH_PYTHON_RELEASES)),--withpython)
.PHONY: docker-fedora21 endef
docker-fedora21:
mkdir -p $(HGROOT)packages/fedora21
./dockerrpm fedora21
.PHONY: centos5
centos5:
mkdir -p $(HGROOT)/packages/centos5
./buildrpm --withpython
cp $(HGROOT)/rpmbuild/RPMS/*/* $(HGROOT)/packages/centos5
cp $(HGROOT)/rpmbuild/SRPMS/* $(HGROOT)/packages/centos5
.PHONY: docker-centos5
docker-centos5:
mkdir -p $(HGROOT)/packages/centos5
./dockerrpm centos5 --withpython
.PHONY: centos6
centos6:
mkdir -p $(HGROOT)/packages/centos6
./buildrpm --withpython
cp $(HGROOT)/rpmbuild/RPMS/*/* $(HGROOT)/packages/centos6
cp $(HGROOT)/rpmbuild/SRPMS/* $(HGROOT)/packages/centos6
.PHONY: docker-centos6
docker-centos6:
mkdir -p $(HGROOT)/packages/centos6
./dockerrpm centos6 --withpython
.PHONY: centos7
centos7:
mkdir -p $(HGROOT)/packages/centos7
./buildrpm
cp $(HGROOT)/rpmbuild/RPMS/*/* $(HGROOT)/packages/centos7
cp $(HGROOT)/rpmbuild/SRPMS/* $(HGROOT)/packages/centos7
.PHONY: docker-centos7 $(foreach release,$(CENTOS_RELEASES),$(eval $(call centos_targets,$(release))))
docker-centos7:
mkdir -p $(HGROOT)/packages/centos7
./dockerrpm centos7
.PHONY: linux-wheels .PHONY: linux-wheels
linux-wheels: linux-wheels-x86_64 linux-wheels-i686 linux-wheels: linux-wheels-x86_64 linux-wheels-i686
.PHONY: linux-wheels-x86_64 .PHONY: linux-wheels-x86_64
linux-wheels-x86_64: linux-wheels-x86_64:
docker run -e "HGTEST_JOBS=$(shell nproc)" --rm -ti -v `pwd`/../..:/src quay.io/pypa/manylinux1_x86_64 /src/contrib/packaging/build-linux-wheels.sh docker run -e "HGTEST_JOBS=$(shell nproc)" --rm -ti -v `pwd`/../..:/src quay.io/pypa/manylinux1_x86_64 /src/contrib/packaging/build-linux-wheels.sh
.PHONY: linux-wheels-i686 .PHONY: linux-wheels-i686
linux-wheels-i686: linux-wheels-i686:
docker run -e "HGTEST_JOBS=$(shell nproc)" --rm -ti -v `pwd`/../..:/src quay.io/pypa/manylinux1_i686 linux32 /src/contrib/packaging/build-linux-wheels.sh docker run -e "HGTEST_JOBS=$(shell nproc)" --rm -ti -v `pwd`/../..:/src quay.io/pypa/manylinux1_i686 linux32 /src/contrib/packaging/build-linux-wheels.sh