( )⚙ D3803 patchbomb: don't close unused progress topic

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3803

patchbomb: don't close unused progress topic
ClosedPublic

Authored by martinvonz on Jun 18 2018, 8:44 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG457fa4056286: patchbomb: don't close unused progress topic
Summary

The "writing" topic has not been used since 1830d0cc4bc1 (patchbomb:
minor refactoring of mbox functionality, preparing for move,
2011-11-23).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 18 2018, 8:44 PM
pulkit accepted this revision.Jun 19 2018, 6:59 AM
Closed by commit rHG457fa4056286: patchbomb: don't close unused progress topic (authored by martinvonz). · Explain WhyJun 19 2018, 7:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/patchbomb.py (1 line)

Diff 9219

hgext/patchbomb.py

if not mbox: if not mbox:
# Exim does not remove the Bcc field # Exim does not remove the Bcc field
del m['Bcc'] del m['Bcc']
fp = stringio() fp = stringio()
generator = emailgen.Generator(fp, mangle_from_=False) generator = emailgen.Generator(fp, mangle_from_=False)
generator.flatten(m, 0) generator.flatten(m, 0)
sendmail(sender_addr, to + bcc + cc, fp.getvalue()) sendmail(sender_addr, to + bcc + cc, fp.getvalue())
ui.progress(_('writing'), None)
ui.progress(_('sending'), None) ui.progress(_('sending'), None)