This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3804

patchbomb: use progress helper
ClosedPublic

Authored by martinvonz on Jun 18 2018, 8:44 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8ce3f91d5f6f: patchbomb: use progress helper
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 18 2018, 8:44 PM
pulkit accepted this revision.Jun 19 2018, 6:59 AM
Closed by commit rHG8ce3f91d5f6f: patchbomb: use progress helper (authored by martinvonz). · Explain WhyJun 19 2018, 7:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/patchbomb.py (6 lines)

Diff 9220

hgext/patchbomb.py

parent = '<' + parent parent = '<' + parent
if not parent.endswith('>'): if not parent.endswith('>'):
parent += '>' parent += '>'
sender_addr = eutil.parseaddr(encoding.strfromlocal(sender))[1] sender_addr = eutil.parseaddr(encoding.strfromlocal(sender))[1]
sender = mail.addressencode(ui, sender, _charsets, opts.get('test')) sender = mail.addressencode(ui, sender, _charsets, opts.get('test'))
sendmail = None sendmail = None
firstpatch = None firstpatch = None
progress = ui.makeprogress(_('sending'), unit=_('emails'), total=len(msgs))
for i, (m, subj, ds) in enumerate(msgs): for i, (m, subj, ds) in enumerate(msgs):
try: try:
m['Message-Id'] = genmsgid(m['X-Mercurial-Node']) m['Message-Id'] = genmsgid(m['X-Mercurial-Node'])
if not firstpatch: if not firstpatch:
firstpatch = m['Message-Id'] firstpatch = m['Message-Id']
m['X-Mercurial-Series-Id'] = firstpatch m['X-Mercurial-Series-Id'] = firstpatch
except TypeError: except TypeError:
m['Message-Id'] = genmsgid('patchbomb') m['Message-Id'] = genmsgid('patchbomb')
ui.write('\n') ui.write('\n')
except IOError as inst: except IOError as inst:
if inst.errno != errno.EPIPE: if inst.errno != errno.EPIPE:
raise raise
else: else:
if not sendmail: if not sendmail:
sendmail = mail.connect(ui, mbox=mbox) sendmail = mail.connect(ui, mbox=mbox)
ui.status(_('sending '), subj, ' ...\n') ui.status(_('sending '), subj, ' ...\n')
ui.progress(_('sending'), i, item=subj, total=len(msgs), progress.update(i, item=subj)
unit=_('emails'))
if not mbox: if not mbox:
# Exim does not remove the Bcc field # Exim does not remove the Bcc field
del m['Bcc'] del m['Bcc']
fp = stringio() fp = stringio()
generator = emailgen.Generator(fp, mangle_from_=False) generator = emailgen.Generator(fp, mangle_from_=False)
generator.flatten(m, 0) generator.flatten(m, 0)
sendmail(sender_addr, to + bcc + cc, fp.getvalue()) sendmail(sender_addr, to + bcc + cc, fp.getvalue())
ui.progress(_('sending'), None) progress.complete()