This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3812

tests: use progress helper
ClosedPublic

Authored by martinvonz on Jun 18 2018, 8:45 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG26523316e4d0: tests: use progress helper
Summary

With this commit, the only in-tree caller of ui.progress() is
scmutil.progress(). That means that we could deprecate it. It also
means that we can considering inlining it in scmutil.progress.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Jun 18 2018, 8:45 PM
pulkit accepted this revision.Jun 19 2018, 7:14 AM
Closed by commit rHG26523316e4d0: tests: use progress helper (authored by martinvonz). · Explain WhyJun 19 2018, 7:18 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/test-progress.t (16 lines)

Diff 9214

tests/test-progress.t

> total = loops > total = loops
> if opts.get('total', None): > if opts.get('total', None):
> total = int(opts.get('total')) > total = int(opts.get('total'))
> nested = False > nested = False
> if opts.get('nested', None): > if opts.get('nested', None):
> nested = True > nested = True
> loops = abs(loops) > loops = abs(loops)
> >
> progress = ui.makeprogress(topiclabel, unit='loopnum', total=total)
> other = ui.makeprogress('other', unit='othernum', total=total)
> for i in range(loops): > for i in range(loops):
> ui.progress(topiclabel, i, getloopitem(i), 'loopnum', total) > progress.update(i, item=getloopitem(i))
> if opts.get('parallel'): > if opts.get('parallel'):
> ui.progress('other', i, 'other.%d' % i, 'othernum', total) > other.update(i, item='other.%d' % i)
> if nested: > if nested:
> nested_steps = 2 > nested_steps = 2
> if i and i % 4 == 0: > if i and i % 4 == 0:
> nested_steps = 5 > nested_steps = 5
> nested = ui.makeprogress('nested', unit='nestnum',
> total=nested_steps)
> for j in range(nested_steps): > for j in range(nested_steps):
> ui.progress( > nested.update(j, item='nested.%d' % j)
> 'nested', j, 'nested.%d' % j, 'nestnum', nested_steps) > nested.complete()
> ui.progress( > progress.complete()
> 'nested', None, 'nested.done', 'nestnum', nested_steps)
> ui.progress(topiclabel, None, 'loop.done', 'loopnum', total)
> >
> topiclabel = 'loop' > topiclabel = 'loop'
> def getloopitem(i): > def getloopitem(i):
> return 'loop.%d' % i > return 'loop.%d' % i
> >
> EOF > EOF
$ cp $HGRCPATH $HGRCPATH.orig $ cp $HGRCPATH $HGRCPATH.orig