Page MenuHomePhabricator

grep: deprecates `--all` flag
ClosedPublic

Authored by sangeet259 on Jun 21 2018, 12:01 PM.

Details

Summary

As the name "all" is a misnomer for an option that searches on diffs of revisions,
we are moving to diff flag from all, deprecating it in the process.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sangeet259 created this revision.Jun 21 2018, 12:01 PM
yuja added a subscriber: yuja.Jun 22 2018, 7:42 AM

@command('grep',

[('0', 'print0', None, _('end fields with NUL')),
  • ('', 'all', None, _('print all revisions that match')),

+ ('', 'all', None, _('print all revisions that match (DEPRECATED)')),

('', 'diff', None, _('print all revisions when the term was introduced or removed')),

This doesn't apply. Can you rebase onto the current tip?

pulkit added a subscriber: pulkit.Jun 22 2018, 9:00 AM
pulkit added inline comments.
mercurial/commands.py
2522

Drop the mention of --all flag from here.

sangeet259 edited the summary of this revision. (Show Details)Jun 28 2018, 1:52 PM
sangeet259 updated this revision to Diff 9339.
sangeet259 updated this revision to Diff 9340.Jun 28 2018, 1:55 PM
pulkit accepted this revision.Jun 28 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.