This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3825

grep: deprecates `--all` flag
ClosedPublic

Authored by sangeet259 on Jun 21 2018, 12:01 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8d9d0d30cfcc: grep: deprecates `--all` flag
Summary

As the name "all" is a misnomer for an option that searches on diffs of revisions,
we are moving to diff flag from all, deprecating it in the process.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sangeet259 created this revision.Jun 21 2018, 12:01 PM
yuja added a subscriber: yuja.Jun 22 2018, 7:42 AM

@command('grep',

[('0', 'print0', None, _('end fields with NUL')),
  • ('', 'all', None, _('print all revisions that match')),

+ ('', 'all', None, _('print all revisions that match (DEPRECATED)')),

('', 'diff', None, _('print all revisions when the term was introduced or removed')),

This doesn't apply. Can you rebase onto the current tip?

pulkit added a subscriber: pulkit.Jun 22 2018, 9:00 AM
pulkit added inline comments.
mercurial/commands.py
2522

Drop the mention of --all flag from here.

sangeet259 edited the summary of this revision. (Show Details)Jun 28 2018, 1:52 PM
sangeet259 updated this revision to Diff 9339.
sangeet259 updated this revision to Diff 9340.Jun 28 2018, 1:55 PM
pulkit accepted this revision.Jun 28 2018, 2:01 PM
Closed by commit rHG8d9d0d30cfcc: grep: deprecates `--all` flag (authored by sangeet259). · Explain WhyJun 28 2018, 2:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/commands.py (4 lines)

Diff 9341

mercurial/commands.py

hg.updaterepo(repo, pctx.node(), True) hg.updaterepo(repo, pctx.node(), True)
graftstate.delete() graftstate.delete()
ui.status(_("stopped the interrupted graft\n")) ui.status(_("stopped the interrupted graft\n"))
ui.status(_("working directory is now at %s\n") % pctx.hex()[:12]) ui.status(_("working directory is now at %s\n") % pctx.hex()[:12])
return 0 return 0
@command('grep', @command('grep',
[('0', 'print0', None, _('end fields with NUL')), [('0', 'print0', None, _('end fields with NUL')),
('', 'all', None, _('print all revisions that match')), ('', 'all', None, _('print all revisions that match (DEPRECATED) ')),
('', 'diff', None, _('print all revisions when the term was introduced ' ('', 'diff', None, _('print all revisions when the term was introduced '
'or removed')), 'or removed')),
('a', 'text', None, _('treat all files as text')), ('a', 'text', None, _('treat all files as text')),
('f', 'follow', None, ('f', 'follow', None,
_('follow changeset history,' _('follow changeset history,'
' or file history across copies and renames')), ' or file history across copies and renames')),
('i', 'ignore-case', None, _('ignore case when matching')), ('i', 'ignore-case', None, _('ignore case when matching')),
('l', 'files-with-matches', None, ('l', 'files-with-matches', None,
Search revision history for a regular expression in the specified Search revision history for a regular expression in the specified
files or the entire project. files or the entire project.
By default, grep prints the most recent revision number for each By default, grep prints the most recent revision number for each
file in which it finds a match. To get it to print every revision file in which it finds a match. To get it to print every revision
that contains a change in match status ("-" for a match that becomes that contains a change in match status ("-" for a match that becomes
a non-match, or "+" for a non-match that becomes a match), use the a non-match, or "+" for a non-match that becomes a match), use the
--diff/--all flag. --diff flag.
pulkitUnsubmitted
Not Done

Drop the mention of --all flag from here.

pulkit: Drop the mention of `--all` flag from here.
PATTERN can be any Python (roughly Perl-compatible) regular PATTERN can be any Python (roughly Perl-compatible) regular
expression. expression.
If no FILEs are specified (and -f/--follow isn't set), all files in If no FILEs are specified (and -f/--follow isn't set), all files in
the repository are searched, including those that don't exist in the the repository are searched, including those that don't exist in the
current branch or have been deleted in a prior changeset. current branch or have been deleted in a prior changeset.