( )⚙ D3847 fix: disallow 'hg fix --base <rev> --whole'

This is an archive of the discontinued Mercurial Phabricator instance.

fix: disallow 'hg fix --base <rev> --whole'
ClosedPublic

Authored by hooper on Jun 26 2018, 9:07 PM.

Details

Summary

The two flags have conflicting meaning, so we shouldn't pretend to honor both
(otherwise, --whole takes precedence in the current implementation).

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hooper created this revision.Jun 26 2018, 9:07 PM
durin42 accepted this revision as: durin42.Jun 29 2018, 9:10 PM
hooper added a comment.Jul 3 2018, 7:57 PM

Let's not commit this one if possible. I have another patch with a test case that shows the combination is useful.

This revision was automatically updated to reflect the committed changes.
yuja added a subscriber: yuja.Jul 4 2018, 8:36 AM
Let's not commit this one if possible. I have another patch with a test

case that shows the combination is useful.

Oops. Pruned from the hg-committed repository. Next time, can you exclude
this kind of patches from the series somehow?