This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3851

tests: pass "rev" argument to commands.update() as string
ClosedPublic

Authored by martinvonz on Jun 28 2018, 1:13 AM.

Download Raw Diff

Details

Reviewers

pulkit

Group Reviewers

hg-reviewers

Commits

rHGecaa0ad4ed4f: tests: pass "rev" argument to commands.update() as string

Summary

commands.update() normally gets its "rev" argument as a string, but
test-basic.t was passing an integer. That happened to work, but we
shouldn't rely on it.

Diff Detail

Repository

rHG Mercurial

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 28 2018, 1:13 AM

Herald added a reviewer: hg-reviewers. · View Herald TranscriptJun 28 2018, 1:13 AM

Herald added a subscriber: mercurial-devel. · View Herald Transcript

martinvonz added a child revision: D3852: namespaces: let namespaces override singlenode() definition.Jun 28 2018, 1:13 AM

martinvonz updated this revision to Diff 9332.

pulkit accepted this revision.Jun 28 2018, 5:42 AM

pulkit added inline comments.Jun 28 2018, 5:56 AM

tests/test-basic.t
67	Added a b'' prefix in flight for py3.

Closed by commit rHGecaa0ad4ed4f: tests: pass "rev" argument to commands.update() as string (authored by martinvonz). · Explain WhyJun 28 2018, 5:59 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			tests/test-basic.t (2 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	9330		Jun 28 2018, 1:13 AM	★	★
Diff 2	9332		Jun 28 2018, 1:14 AM	★	★
Diff 3	9334	rHGecaa0ad4ed4f421bedf344e1b79ecd7d4952007c	Jun 27 2018, 10:19 AM	★	★

	Status	Author	Revision
	Closed	martinvonz	D3852 namespaces: let namespaces override singlenode() definition
	Closed	martinvonz	D3851 tests: pass "rev" argument to commands.update() as string

Diff 9334

tests/test-basic.t



	Verify that updating to revision 0 via commands.update() works properly			Verify that updating to revision 0 via commands.update() works properly

	$ cat <<EOF > update_to_rev0.py			$ cat <<EOF > update_to_rev0.py
	> from mercurial import ui, hg, commands			> from mercurial import ui, hg, commands
	> myui = ui.ui.load()			> myui = ui.ui.load()
	> repo = hg.repository(myui, path=b'.')			> repo = hg.repository(myui, path=b'.')
	> commands.update(myui, repo, rev=0)			> commands.update(myui, repo, rev=b"0")
				pulkitUnsubmitted Not Done Added a b'' prefix in flight for py3. pulkit: Added a b'' prefix in flight for py3.
	> EOF			> EOF
	$ hg up null			$ hg up null
	0 files updated, 0 files merged, 1 files removed, 0 files unresolved			0 files updated, 0 files merged, 1 files removed, 0 files unresolved
	$ $PYTHON ./update_to_rev0.py			$ $PYTHON ./update_to_rev0.py
	1 files updated, 0 files merged, 0 files removed, 0 files unresolved			1 files updated, 0 files merged, 0 files removed, 0 files unresolved
	$ hg identify -n			$ hg identify -n
	0			0