( )⚙ D3860 httppeer: fix use of uninitialized variable with devel logging

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3860

httppeer: fix use of uninitialized variable with devel logging
ClosedPublic

Authored by martinvonz on Jun 29 2018, 5:31 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG2279d90eed9a: httppeer: fix use of uninitialized variable with devel logging
Summary

If the request fails, "res" was uninitialized.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jun 29 2018, 5:31 PM
durin42 accepted this revision.Jun 29 2018, 9:06 PM
This revision is now accepted and ready to land.Jun 29 2018, 9:06 PM
Closed by commit rHG2279d90eed9a: httppeer: fix use of uninitialized variable with devel logging (authored by martinvonz). · Explain WhyJun 30 2018, 7:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/httppeer.py (4 lines)

Diff 9379

mercurial/httppeer.py

if data is not None: if data is not None:
length = getattr(data, 'length', None) length = getattr(data, 'length', None)
if length is None: if length is None:
length = len(data) length = len(data)
dbg(line % ' %d bytes of data' % length) dbg(line % ' %d bytes of data' % length)
start = util.timer() start = util.timer()
res = None
try: try:
res = opener.open(req) res = opener.open(req)
except urlerr.httperror as inst: except urlerr.httperror as inst:
if inst.code == 401: if inst.code == 401:
raise error.Abort(_('authorization failed')) raise error.Abort(_('authorization failed'))
raise raise
except httplib.HTTPException as inst: except httplib.HTTPException as inst:
ui.debug('http error requesting %s\n' % ui.debug('http error requesting %s\n' %
util.hidepassword(req.get_full_url())) util.hidepassword(req.get_full_url()))
ui.traceback() ui.traceback()
raise IOError(None, inst) raise IOError(None, inst)
finally: finally:
if ui.debugflag and ui.configbool('devel', 'debug.peer-request'): if ui.debugflag and ui.configbool('devel', 'debug.peer-request'):
code = res.code if res else -1
dbg(line % ' finished in %.4f seconds (%d)' dbg(line % ' finished in %.4f seconds (%d)'
% (util.timer() - start, res.code)) % (util.timer() - start, code))
# Insert error handlers for common I/O failures. # Insert error handlers for common I/O failures.
_wraphttpresponse(res) _wraphttpresponse(res)
return res return res
class RedirectedRepoError(error.RepoError): class RedirectedRepoError(error.RepoError):
def __init__(self, msg, respurl): def __init__(self, msg, respurl):