( )⚙ D3861 scmutil: fix __enter__ in progress context manager

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D3861

scmutil: fix __enter__ in progress context manager
ClosedPublic

Authored by hooper on Jun 29 2018, 5:52 PM.

Details

Reviewers
durin42
Group Reviewers
hg-reviewers
Commits
rHG077301ac69dc: scmutil: fix __enter__ in progress context manager
Summary

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

hooper created this revision.Jun 29 2018, 5:52 PM
durin42 accepted this revision.Jun 29 2018, 9:08 PM
This revision is now accepted and ready to land.Jun 29 2018, 9:08 PM
Closed by commit rHG077301ac69dc: scmutil: fix __enter__ in progress context manager (authored by hooper). · Explain WhyJun 30 2018, 7:04 PM
This revision was automatically updated to reflect the committed changes.
hooper updated this revision to Diff 9402.Jul 1 2018, 6:43 PM

Revision Contents
Changeset List

PathPackages
Mmercurial/scmutil.py (2 lines)

Diff 9380

mercurial/scmutil.py

def __init__(self, ui, topic, unit="", total=None): def __init__(self, ui, topic, unit="", total=None):
self.ui = ui self.ui = ui
self.pos = 0 self.pos = 0
self.topic = topic self.topic = topic
self.unit = unit self.unit = unit
self.total = total self.total = total
def __enter__(self): def __enter__(self):
pass return self
def __exit__(self, exc_type, exc_value, exc_tb): def __exit__(self, exc_type, exc_value, exc_tb):
self.complete() self.complete()
def update(self, pos, item="", total=None): def update(self, pos, item="", total=None):
assert pos is not None assert pos is not None
if total: if total:
self.total = total self.total = total